feat: store MAINTENANCE_LEVELS as object, not array
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
approved these changes
Jan 16, 2025
Comment on lines
+52
to
+57
| maintenanceLevel: | ||
| urlMaintenanceLevel === "high" || | ||
| urlMaintenanceLevel === "medium" || | ||
| urlMaintenanceLevel === "low" || | ||
| urlMaintenanceLevel === "none" | ||
| ? urlMaintenanceLevel |
There was a problem hiding this comment.
Suggested change
| maintenanceLevel: | |
| urlMaintenanceLevel === "high" || | |
| urlMaintenanceLevel === "medium" || | |
| urlMaintenanceLevel === "low" || | |
| urlMaintenanceLevel === "none" | |
| ? urlMaintenanceLevel | |
| maintenanceLevel: ["high", "medium", "low", "none"].includes(urlMaintenanceLevel) | |
| ? urlMaintenanceLevel |
| @@ -40,7 +38,7 @@ export class Property { | |||
| * Size of the house in square meters | |||
| */ | |||
| size: number; | |||
| maintenancePercentage: MaintenancePercentage; | |||
| maintenanceLevel: 'none' | 'low' | 'medium' | 'high'; | |||
There was a problem hiding this comment.
Suggested change
| maintenanceLevel: 'none' | 'low' | 'medium' | 'high'; | |
| maintenanceLevel: MaintenanceLevel |
| @@ -112,8 +110,10 @@ export class Property { | |||
| componentKey: keyof houseBreakdownType, | |||
| newBuildPrice: number, | |||
| age: number, | |||
| maintenanceLevel: number | |||
| maintenanceLevel: keyof typeof MAINTENANCE_LEVELS | |||
There was a problem hiding this comment.
Suggested change
| maintenanceLevel: keyof typeof MAINTENANCE_LEVELS | |
| maintenanceLevel: MaintenanceLevel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MAINTENANCE_LEVELSconstant an object, not array; and exports a new typeMaintenanceLevelfor the keysMAINTENANCE_LEVELSI found this unused component; following the principle of deleting unused code (Slack thread) because we have access to Git history, I've opted for deleting it (since it's not in the current Miro design anyway) and it meant one less thing to fix.Why?
While starting on #251, I realised that we should update the data type of the
MAINTENANCE_LEVELSconstant first (before having to update it in more places).This also just makes code more legible and useful in cases where we want the level itself (eg
lowand now the value eg0.015).Closes #274