Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tenure selector colours and update shape #295

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

zz-hh-aa
Copy link
Collaborator

@zz-hh-aa zz-hh-aa commented Jan 23, 2025

  • Renamed {tenure}-maintenance-color to {tenure}-detail-color since we are using the colours not just for maintenance but also for the background of the TenureSelector component, as per Alastair's designs
  • Rounded the corners too 😮 again per design
    Design:
    image

Current UI:
image

Would appreciate some feedback on colours, concerned about contrast!

@zz-hh-aa zz-hh-aa requested a review from a team January 23, 2025 12:38
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 11:04am

Base automatically changed from oz/lifetime-graphs to main January 24, 2025 10:53
@zz-hh-aa zz-hh-aa force-pushed the oz/tenure-selector-colours branch from 131ff8e to eefbbfb Compare January 24, 2025 11:02
@zz-hh-aa zz-hh-aa merged commit 7c255a0 into main Jan 24, 2025
5 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/tenure-selector-colours branch January 24, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants