Skip to content

Commit

Permalink
build: update node and pnpm versions & drop package.json engines (#360
Browse files Browse the repository at this point in the history
)
  • Loading branch information
jessicamcinchak authored Aug 9, 2023
1 parent dd848b9 commit 793811b
Show file tree
Hide file tree
Showing 5 changed files with 1,169 additions and 1,139 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pnpm-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ on:
- main

env:
PNPM_VERSION: 7.9.0
NODE_VERSION: 16.14.2 # LTS
PNPM_VERSION: 8.6.6
NODE_VERSION: 18.16.1

jobs:
vitest:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.14.2
v18.16.1
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<div style="display:flex;flex-direction:column;">
<h1 style="color:red;font-size:16px;">*** This is a testing sandbox - these components are unaware of each other! ***</h1>
<div style="margin-bottom:1em">
<my-map zoom="20" maxZoom="23" id="example-map" useScaleBarStyle showScale showNorthArrow showPrint osProxyEndpoint="https://api.editor.planx.dev/proxy/ordnance-survey" />
<my-map zoom="20" maxZoom="23" id="example-map" drawMode useScaleBarStyle showScale showNorthArrow showPrint osProxyEndpoint="https://api.editor.planx.dev/proxy/ordnance-survey" />
</div>
<div style="margin-bottom:1em">
<postcode-search hintText="Optional hint text shows up here" id="example-postcode" />
Expand Down
4 changes: 0 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@
"vitest": "0.34.1",
"wait-for-expect": "^3.0.2"
},
"engines": {
"node": "^16",
"pnpm": "^7.8.0"
},
"lint-staged": {
"src/**/*.{js,jsx,ts,tsx,json,css,scss,md,html}": "prettier --write"
},
Expand Down
Loading

0 comments on commit 793811b

Please sign in to comment.