-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use release-it
for quick deployments
#135
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
"after:git:release": [], | ||
"after:release": "echo Successfully released ${name} v${version} to ${repo.repository}." | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems smart, I like it! i noticed changelog notes in the screencast too, but don't see any reference to those here - am i understanding it right that the changelog is auto-generated based on any commits to main since last publish - will it just tack those onto our existing CHANGELOG.md
?
was originally thinking a publish/release action would be kicked off by any PR merge where we edit package.json version & changelog, but if changelog notes are auto generated here and you can pick the version number during the run, then this fully negates the step of opening that PR altogether, am I understanding that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, can someone with write access to the repo, but not npm org/package, run pnpm release
successfully from main? not sure i understand how npm permissions are being handled here - an env secret in repo settings??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah so once this is running from GH actions we could create an auth token in NPM that we can store in github secrets, but right now only people in the opensystemslab org on npm would be authorised to push a new release from their local machines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- for now you won't need to open a PR for new releases, just run
pnpm release
from main when it's ready to go and it will auto-bump the package.json version number and move what's in unreleased in the changelog into a new release section. Added some details in a new comment below :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant, thanks for explaining!
release-it.movin the video I say no to the npm/github push etc, normally you'd just hit enter (Y) for all of these OK so if we keep an So flow would be:
we could probably run all this from github actions and automate the pull request changes in the doc too but maybe we take it one step at a time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy for this to merge whenever & try it out for our next release!
this might be a quicker way to publish to npm and create the github release?
when you are ready to publish a new build just go to the main branch locally, make sure everything has been committed and there are no changes left to publish then run
pnpm release
it will prompt you but you can press ENTER for pretty much everything, the only thing you'd need to read is when it asks if you're publishing a breaking change i.e. picking the version number
dry run example https://asciinema.org/a/q6WJ5ISD9kej0YbA7BXIiPd0Q?speed=3
related #30