wip: update digital planning schema types and map to passport #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess/export-digital-planning-schema
…ess/export-digital-planning-schema
DafyddLlyr
approved these changes
Sep 29, 2023
| @@ -64,28 +77,13 @@ export class DigitalPlanning { | |||
| }, | |||
| session: { | |||
| source: "PlanX", | |||
| id: "b3320abe-f5bc-4185-b61f-40e9e65f07ad", | |||
| id: "b3320abe-f5bc-4185-b61f-40e9e65f07ad", // this.sessionId throws 'must match format UUID' error | |||
There was a problem hiding this comment.
Ah this is an interesting one, thanks for the comment
| } | ||
|
|
||
| private getApplicationType(): Payload["data"]["application"]["type"] { | ||
| // @todo figure out how to lookup via exported type or schema.json ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
schema.jsonand generated new typesPayload["data"]type - this is a bit patchy and tedious as schema is still changing tooThis is enough of a start to satisfy the planx-new admin endpoint work over here theopensystemslab/planx-new#2223
Next steps:
generateDigitalPlanningDataPayloadexport function onmainbranch