refactor: Make redaction explicit in ExportClient
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/simplify-redaction-calls
branch
from
f93f3cc to
65f07f1
Compare
DafyddLlyr
force-pushed
the
dp/simplify-redaction-calls
branch
from
65f07f1 to
8be6bd2
Compare
DafyddLlyr
changed the title
ExportClient
jessicamcinchak
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes redaction of export payloads explicit. Currently we always generate both a redacted and non-redacted payload per request which needlessly calls an expensive operation twice. The aim here is to make PlanX submissions run a bit more smoothly and quickly.
Implemented in theopensystemslab/planx-new#2313
Also...
ExportClientgenerateOneAppXML()from requests to export