-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update planx-core to ESM module #601
Conversation
6b20104
to
f2f555b
Compare
e3d48dc
to
d004278
Compare
d004278
to
b384d9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this !! Dense changes indeed but all looks good here - and corresponding planx-new PR/pizza seems healthy 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Brings up happy mems of doing the same for the API 😅
My only question is whether there is some way to simplify the tsconfig setup? e.g. is one an extension of another. and can be represented as such? could the base tsconfig.json
replace any of the particular tsconfig.x.json
files? haven't looked at it closely, but just a thought!
b384d9c
to
5c89f50
Compare
This reverts commit f8cdf5b.
What does this PR do?
.js
in filenamesSome of these changes were a bit haphazard - one following the other as I hit issues. If anything is too unclear / too big, please shout and I'll work on splitting this up.
Why?