fix: support separate submission and guidance content & add delay between graphql operations #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Jan 24, 2024
| @@ -79,6 +79,9 @@ ask.start(); | |||
| } catch (error) { | |||
| console.log(chalk.red(error)); | |||
| } | |||
|
|
|||
| // wait 5 seconds before proceeding through next item in loop to avoid Hasura timeouts | |||
| await delay(5000); | |||
There was a problem hiding this comment.
Honestly, this only sort-of helped the FOI issue - I still added a limit & offset when fetching flows. But since this is going to be a one-time run, I think we can just live with that manual limit/offset on that scenario?
I'll make sure to wait to run on prod until after hours though in case we trigger downtime.
DafyddLlyr
approved these changes
Jan 24, 2024
jessicamcinchak
deleted the
jess/support-separate-submission-guidance-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing two things here: