feat: remove onDelete for Placeholder tag for non Platform admiins
#6751
RODO94pull-request.yml
on: pull_request
Check file changes
5s
Run Integration tests
4m 35s
Run API Tests
0s
Run React Tests
3m 1s
Generate Hasura Change Summary
0s
E2E tests
59m 29s
Run Pulumi Preview
0s
Run Healthcheck on Pizza Services
1m 11s
Annotations
20 errors, 12 warnings, and 1 notice
|
src/routes/utils.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/components/Error/GraphError.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/components/Feedback/index.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/components/Header/Header.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/pages/Preview/SaveAndReturn.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/@planx/components/AddressInput/Public.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/@planx/components/Calculate/Public.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/@planx/components/Calculate/logic.test.ts:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/@planx/components/Checklist/Public.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
src/@planx/components/Confirmation/Public.test.tsx:
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Tag.tsx#L16
TypeError: Cannot read properties of undefined (reading 'getState')
❯ src/pages/FlowEditor/components/Flow/components/Tag.tsx:16:26
❯ src/pages/FlowEditor/components/Flow/components/Checklist.tsx:13:32
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L1
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Test timeout of 45000ms exceeded.
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/helpers/getPage.ts#L13
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Error: page.waitForResponse: Test ended.
at helpers/getPage.ts:13
11 | const page = await createAuthenticatedSession({ browser, userId });
12 | await page.goto("/");
> 13 | await page.waitForResponse((response) => {
| ^
14 | return response.url().includes("/graphql");
15 | });
16 | return page;
at getAdminPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:13:14)
at getTeamPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:28:16)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts:36:18
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L1
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 45000ms exceeded.
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/helpers/getPage.ts#L13
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForResponse: Test ended.
at helpers/getPage.ts:13
11 | const page = await createAuthenticatedSession({ browser, userId });
12 | await page.goto("/");
> 13 | await page.waitForResponse((response) => {
| ^
14 | return response.url().includes("/graphql");
15 | });
16 | return page;
at getAdminPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:13:14)
at getTeamPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:28:16)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts:36:18
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L1
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 45000ms exceeded.
|
|
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation:
e2e/tests/ui-driven/src/helpers/getPage.ts#L13
1) [chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: page.waitForResponse: Test ended.
at helpers/getPage.ts:13
11 | const page = await createAuthenticatedSession({ browser, userId });
12 | await page.goto("/");
> 13 | await page.waitForResponse((response) => {
| ^
14 | return response.url().includes("/graphql");
15 | });
16 | return page;
at getAdminPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:13:14)
at getTeamPage (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/helpers/getPage.ts:28:16)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts:36:18
|
|
[chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L1
2) [chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation, publish and preview › Publish and preview flow with geospatial components
Test timeout of 45000ms exceeded.
|
|
[chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L82
2) [chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation, publish and preview › Publish and preview flow with geospatial components
Error: locator.click: Test ended.
Call log:
- waiting for getByRole('button', { name: 'CHECK FOR CHANGES TO PUBLISH' })
80 | // publish flow
81 | await page.goto(`/${context.team.slug}/${serviceProps.slug}`);
> 82 | page.getByRole("button", { name: "CHECK FOR CHANGES TO PUBLISH" }).click();
| ^
83 | page.getByRole("button", { name: "PUBLISH", exact: true }).click();
84 |
85 | let previewLink = page.getByRole("link", {
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts:82:72
|
|
[chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L1
2) [chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation, publish and preview › Publish and preview flow with geospatial components
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 45000ms exceeded.
|
|
[chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation:
e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts#L82
2) [chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation, publish and preview › Publish and preview flow with geospatial components
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test ended.
Call log:
- waiting for getByRole('button', { name: 'CHECK FOR CHANGES TO PUBLISH' })
80 | // publish flow
81 | await page.goto(`/${context.team.slug}/${serviceProps.slug}`);
> 82 | page.getByRole("button", { name: "CHECK FOR CHANGES TO PUBLISH" }).click();
| ^
83 | page.getByRole("button", { name: "PUBLISH", exact: true }).click();
84 |
85 | let previewLink = page.getByRole("link", {
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts:82:72
|
|
Check file changes
The following actions use a deprecated Node.js version and will be forced to run on node20: dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run React Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Integration tests
The following actions use a deprecated Node.js version and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts#L97
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L88
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L97
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L132
Unexpected use of networkidle
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › save-and-return.spec.ts#L1
e2e/tests/ui-driven/[chromium] › save-and-return.spec.ts took 13.5m
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › create-flow.spec.ts#L1
e2e/tests/ui-driven/[chromium] › create-flow.spec.ts took 13.5m
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › sections.spec.ts#L1
e2e/tests/ui-driven/[chromium] › sections.spec.ts took 11.2m
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › create-flow-with-geospatial.spec.ts#L1
e2e/tests/ui-driven/[chromium] › create-flow-with-geospatial.spec.ts took 4.5m
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › login.spec.ts#L1
e2e/tests/ui-driven/[chromium] › login.spec.ts took 4.5m
|
|
🎭 Playwright Run Summary
21 failed
[chromium] › create-flow-with-geospatial.spec.ts:35:7 › Flow creation, publish and preview › Create a flow
[chromium] › create-flow-with-geospatial.spec.ts:73:7 › Flow creation, publish and preview › Publish and preview flow with geospatial components
[chromium] › create-flow.spec.ts:46:7 › Flow creation, publish and preview › Create a flow ─────
[chromium] › create-flow.spec.ts:98:7 › Flow creation, publish and preview › Cannot preview an unpublished flow
[chromium] › create-flow.spec.ts:115:7 › Flow creation, publish and preview › Publish a flow ───
[chromium] › create-flow.spec.ts:132:7 › Flow creation, publish and preview › Cannot preview an offline flow
[chromium] › create-flow.spec.ts:151:7 › Flow creation, publish and preview › Turn a flow online
[chromium] › create-flow.spec.ts:178:7 › Flow creation, publish and preview › Can preview a published flow
[chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login ──────────────────────
[chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful
[chromium] › save-and-return.spec.ts:47:9 › Save and return › email › email confirmation is required
[chromium] › save-and-return.spec.ts:55:9 › Save and return › email › email confirmation must match
[chromium] › save-and-return.spec.ts:66:9 › Save and return › resuming a saved application › the application presents a review screen on return
[chromium] › save-and-return.spec.ts:92:9 › Save and return › resuming a saved application › the application resumes from the last unanswered question
[chromium] › save-and-return.spec.ts:119:9 › Save and return › session reconciliation › the application resumes with no modifications
[chromium] › save-and-return.spec.ts:142:9 › Save and return › session reconciliation › the application resumes from the first modified question
[chromium] › sections.spec.ts:65:9 › Section statuses › a straight-through journey › not started, ready to start and complete statuses
[chromium] › sections.spec.ts:159:9 › Section statuses › a straight-through journey › started and ready to continue
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
[chromium] › sections.spec.ts:373:9 › Section statuses › simple save and return › the ready to continue status
[chromium] › sections.spec.ts:447:9 › Section statuses › save and return with service changes (reconciliation) › needs new information and started
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
playwright-report
Expired
|
466 KB |
|