chore: showInternalNotes in editor modals for portals
#7190
Triggered via pull request
December 18, 2024 22:49
augustlindemer
Status
Failure
Total duration
10m 11s
Artifacts
–
pull-request.yml
on: pull_request
Check file changes
6s
Run Integration tests
5m 1s
Run API Tests
0s
Run React Tests
6m 49s
Generate Hasura Change Summary
0s
E2E tests
9m 47s
Run Pulumi Preview
0s
Run Healthcheck on Pizza Services
33s
Annotations
5 errors, 6 warnings, and 1 notice
|
src/@planx/components/ExternalPortal/Editor.test.tsx > adding an external portal:
editor.planx.uk/src/@planx/components/ExternalPortal/Editor.test.tsx#L30
AssertionError: expected "spy" to be called with arguments: [ { type: 310, data: { …(2) } } ]
Received:
1st spy call:
Array [
Object {
"data": Object {
"flowId": "b",
+ "notes": "",
"tags": Array [],
},
"type": 310,
},
]
Number of calls: 1
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div>
<form
data-testid="form"
id="modal"
>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CopyAllIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M18 2H9c-1.1 0-2 .9-2 2v12c0 1.1.9 2 2 2h9c1.1 0 2-.9 2-2V4c0-1.1-.9-2-2-2m0 14H9V4h9zM3 15v-2h2v2zm0-5.5h2v2H3zM10 20h2v2h-2zm-7-1.5v-2h2v2zM5 22c-1.1 0-2-.9-2-2h2zm3.5 0h-2v-2h2zm5 0v-2h2c0 1.1-.9 2-2 2M5 6v2H3c0-1.1.9-2 2-2"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
External portal
</h3>
<span>
External portals let you reference all content from another flow inline within this service. Deleting this node does NOT delete the flow that it references.
</span>
</div>
</div>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
/>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Pick a flow
</h3>
<select
data-testid="flowId"
name="flowId"
>
<option
value=""
/>
<option
value="a"
>
flow a
</option>
<option
value="b"
>
flow b
</option>
</select>
</div>
</div>
</div>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="BorderColorIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M22 24H2v-4h20zM13.06 5.19l3.75 3.75L7.75 18H4v-3.75zm4.82 2.68-3.75-3.75 1.83-1.83c.39-.39 1.02-.39 1.41 0l2.34 2.34c.39.39.39 1.02 0 1.41z"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Internal notes
</h3>
<div
class="MuiBox-root css-1vg8n85"
>
<div
class="MuiBox-root css-qsaw8"
|
|
src/@planx/components/ExternalPortal/Editor.test.tsx > changing an external portal:
editor.planx.uk/src/@planx/components/ExternalPortal/Editor.test.tsx#L63
AssertionError: expected "spy" to be called with arguments: [ { type: 310, data: { …(2) } } ]
Received:
1st spy call:
Array [
Object {
"data": Object {
"flowId": "a",
+ "notes": "",
"tags": Array [],
},
"type": 310,
},
]
Number of calls: 1
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div>
<form
data-testid="form"
id="modal"
>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="CopyAllIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M18 2H9c-1.1 0-2 .9-2 2v12c0 1.1.9 2 2 2h9c1.1 0 2-.9 2-2V4c0-1.1-.9-2-2-2m0 14H9V4h9zM3 15v-2h2v2zm0-5.5h2v2H3zM10 20h2v2h-2zm-7-1.5v-2h2v2zM5 22c-1.1 0-2-.9-2-2h2zm3.5 0h-2v-2h2zm5 0v-2h2c0 1.1-.9 2-2 2M5 6v2H3c0-1.1.9-2 2-2"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
External portal
</h3>
<span>
External portals let you reference all content from another flow inline within this service. Deleting this node does NOT delete the flow that it references.
</span>
</div>
</div>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
/>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Pick a flow
</h3>
<select
data-testid="flowId"
name="flowId"
>
<option
value="a"
>
flow a
</option>
<option
value="b"
>
flow b
</option>
</select>
</div>
</div>
</div>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="BorderColorIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M22 24H2v-4h20zM13.06 5.19l3.75 3.75L7.75 18H4v-3.75zm4.82 2.68-3.75-3.75 1.83-1.83c.39-.39 1.02-.39 1.41 0l2.34 2.34c.39.39.39 1.02 0 1.41z"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Internal notes
</h3>
<div
class="MuiBox-root css-1vg8n85"
>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
|
|
src/@planx/components/InternalPortal/Editor.test.tsx > adding an internal portal > creating a new internal portal:
editor.planx.uk/src/@planx/components/InternalPortal/Editor.test.tsx#L36
AssertionError: expected "spy" to be called with arguments: [ { type: 300, data: { …(3) } } ]
Received:
1st spy call:
Array [
Object {
"data": Object {
"flowId": "",
+ "notes": "",
"tags": Array [],
"text": "new internal portal",
},
"type": 300,
},
]
Number of calls: 1
Ignored nodes: comments, script, style
<html>
<head />
<body>
<div>
<form
data-testid="form"
id="modal"
>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="DoorFrontOutlinedIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 19V5c0-1.1-.9-2-2-2H7c-1.1 0-2 .9-2 2v14H3v2h18v-2zm-2 0H7V5h10zm-4-8h2v2h-2z"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Internal Portal
</h3>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
>
<p
class="MuiTypography-root MuiTypography-body1 css-l4bkyg-MuiTypography-root"
/>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
>
<p
class="MuiTypography-root MuiTypography-body1 css-l4bkyg-MuiTypography-root"
data-testid="error-message-portalFlowId"
id="error-message-portalFlowId"
/>
<div
class="MuiInputBase-root MuiInputBase-colorPrimary Mui-focused Input-focused css-13pzt9w-MuiInputBase-root"
>
<input
class="MuiInputBase-input css-1dj7bbi-MuiInputBase-input"
id="portalFlowId"
name="text"
placeholder="Enter a portal name"
rows="2"
type="text"
value="new internal portal"
/>
</div>
</div>
</div>
</div>
</div>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
/>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h4
class="MuiTypography-root MuiTypography-subtitle1 css-72ta6g-MuiTypography-root"
>
Use an existing portal
</h4>
<label
class="css-7wh13m"
for="flowId"
id="flowId-label"
>
<p
class="MuiTypography-root MuiTypography-body1 css-8pd92s-MuiTypography-root"
style="border: 0px; height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; white-space: nowrap; width: 1px;"
>
Use an existing portal
</p>
</label>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
>
<p
class="MuiTypography-root Mu
|
|
src/@planx/components/InternalPortal/Editor.test.tsx > updating an internal portal:
editor.planx.uk/src/@planx/components/InternalPortal/Editor.test.tsx#L128
AssertionError: expected "spy" to be called with arguments: [ { type: 300, data: { …(3) } } ]
Received:
1st spy call:
Array [
Object {
"data": Object {
"flowId": "",
+ "notes": "",
"tags": Array [],
"text": "new val",
},
"type": 300,
},
]
Number of calls: 1
Ignored nodes: comments, script, style
<html>
<head />
<body
style=""
>
<div>
<form
data-testid="form"
id="modal"
>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="DoorFrontOutlinedIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 19V5c0-1.1-.9-2-2-2H7c-1.1 0-2 .9-2 2v14H3v2h18v-2zm-2 0H7V5h10zm-4-8h2v2h-2z"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Internal Portal
</h3>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
>
<p
class="MuiTypography-root MuiTypography-body1 css-l4bkyg-MuiTypography-root"
/>
<div
class="MuiBox-root css-qsaw8"
data-testid="error-wrapper"
role="alert"
>
<p
class="MuiTypography-root MuiTypography-body1 css-l4bkyg-MuiTypography-root"
data-testid="error-message-portalFlowId"
id="error-message-portalFlowId"
/>
<div
class="MuiInputBase-root MuiInputBase-colorPrimary Mui-focused Input-focused css-13pzt9w-MuiInputBase-root"
>
<input
class="MuiInputBase-input css-1dj7bbi-MuiInputBase-input"
id="portalFlowId"
name="text"
placeholder="Enter a portal name"
rows="2"
type="text"
value="new val"
/>
</div>
</div>
</div>
</div>
</div>
</div>
<div
class="modalSection MuiBox-root css-1h2l06g"
>
<div
class="MuiGrid-root MuiGrid-container css-17r7e48-MuiGrid-root"
>
<div
class="MuiGrid-root MuiGrid-item css-1tqt9bz-MuiGrid-root"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-i4bv87-MuiSvgIcon-root"
data-testid="BorderColorIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M22 24H2v-4h20zM13.06 5.19l3.75 3.75L7.75 18H4v-3.75zm4.82 2.68-3.75-3.75 1.83-1.83c.39-.39 1.02-.39 1.41 0l2.34 2.34c.39.39.39 1.02 0 1.41z"
/>
</svg>
</div>
<div
class="MuiGrid-root MuiGrid-item css-1thsrfj-MuiGrid-root"
>
<h3
class="MuiTypography-root MuiTypography-h3 css-1v5cebv-MuiTypography-root"
>
Internal notes
</h3>
<div
class="MuiBox-root css-1vg8n85"
>
<div
class="
|
|
Run React Tests
Process completed with exit code 1.
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts#L97
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L98
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L106
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L140
Unexpected use of networkidle
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › create-flow.spec.ts#L1
e2e/tests/ui-driven/[chromium] › create-flow.spec.ts took 33.5s
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › create-flow-with-geospatial.spec.ts#L1
e2e/tests/ui-driven/[chromium] › create-flow-with-geospatial.spec.ts took 18.8s
|
|
🎭 Playwright Run Summary
22 passed (1.4m)
|