fix: Reduce React re-renders when checking currentCard()
#5078
DafyddLlyrpull-request.yml
on: pull_request
Check file changes
6s
Run Integration tests
5m 6s
Run API Tests
0s
Run React Tests
5m 49s
Generate Hasura Change Summary
0s
E2E tests
12m 8s
Run Pulumi Preview
0s
Run Healthcheck on Pizza Services
0s
Annotations
9 errors, 9 warnings, and 1 notice
|
Run React Tests
Process completed with exit code 1.
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Test timeout of 45000ms exceeded.
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Error: expect(locator).toContainText(expected)
Locator: locator('dl dd')
- Expected - 3
+ Received + 3
Array [
- "COMPLETED",
- "READY TO START",
- "CANNOT START YET",
+ " The status of this section of the application is:READY TO CONTINUE ",
+ " The status of this section of the application is:CANNOT START YET ",
+ " The status of this section of the application is:CANNOT START YET ",
]
Call log:
- expect.toContainText with timeout 45000ms
- waiting for locator('dl dd')
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
at globalHelpers.ts:235
233 | const pageStatuses = page.locator("dl dd");
234 | await expect(pageSections).toContainText(sections.map((s) => s.title));
> 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status));
| ^
236 | }
237 |
238 | export async function fillGovUkCardDetails({
at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 45000ms exceeded.
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toContainText(expected)
Locator: locator('dl dd')
- Expected - 3
+ Received + 3
Array [
- "COMPLETED",
- "READY TO START",
- "CANNOT START YET",
+ " The status of this section of the application is:READY TO CONTINUE ",
+ " The status of this section of the application is:CANNOT START YET ",
+ " The status of this section of the application is:CANNOT START YET ",
]
Call log:
- expect.toContainText with timeout 45000ms
- waiting for locator('dl dd')
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
at globalHelpers.ts:235
233 | const pageStatuses = page.locator("dl dd");
234 | await expect(pageSections).toContainText(sections.map((s) => s.title));
> 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status));
| ^
236 | }
237 |
238 | export async function fillGovUkCardDetails({
at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 45000ms exceeded.
|
|
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started:
e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: expect(locator).toContainText(expected)
Locator: locator('dl dd')
- Expected - 3
+ Received + 3
Array [
- "COMPLETED",
- "READY TO START",
- "CANNOT START YET",
+ " The status of this section of the application is:READY TO CONTINUE ",
+ " The status of this section of the application is:CANNOT START YET ",
+ " The status of this section of the application is:CANNOT START YET ",
]
Call log:
- expect.toContainText with timeout 45000ms
- waiting for locator('dl dd')
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
- locator resolved to 3 elements
at globalHelpers.ts:235
233 | const pageStatuses = page.locator("dl dd");
234 | await expect(pageSections).toContainText(sections.map((s) => s.title));
> 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status));
| ^
236 | }
237 |
238 | export async function fillGovUkCardDetails({
at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
|
|
E2E tests
Process completed with exit code 1.
|
|
Upsert Vultr Instance
Process completed with exit code 1.
|
|
Check file changes
The following actions uses Node.js version which is deprecated and will be forced to run on node20: dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run Integration tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run React Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts#L93
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L87
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L96
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L131
Unexpected use of networkidle
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › sections.spec.ts#L1
e2e/tests/ui-driven/[chromium] › sections.spec.ts took 2.4m
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › create-flow/create-flow.spec.ts#L1
e2e/tests/ui-driven/[chromium] › create-flow/create-flow.spec.ts took 15.5s
|
|
🎭 Playwright Run Summary
1 failed
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses
18 passed (3.3m)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
playwright-report
Expired
|
4.49 MB |
|