Skip to content
Pull Request

fix: Reduce React re-renders when checking currentCard() #5082

Sign in to view logs

fix: Reduce React re-renders when checking currentCard()

fix: Reduce React re-renders when checking currentCard() #5082

Triggered via pull request July 10, 2024 10:46
@DafyddLlyrDafyddLlyr
synchronize #3398
dp/current-card-multiple-renders-bug
Status Failure
Total duration 11m 53s
Artifacts 1

pull-request.yml

on: pull_request
Check file changes
3s
Check file changes
Build React App
4m 3s
Build React App
Run Integration tests
4m 53s
Run Integration tests
Run API Tests
0s
Run API Tests
Run React Tests
5m 27s
Run React Tests
Generate Hasura Change Summary
0s
Generate Hasura Change Summary
E2E tests
11m 33s
E2E tests
Upsert Vultr Instance
2m 16s
Upsert Vultr Instance
Run Pulumi Preview
0s
Run Pulumi Preview
Run Healthcheck on Pizza Services
32s
Run Healthcheck on Pizza Services
Fit to window
Zoom out
Zoom in

Annotations

7 errors, 8 warnings, and 1 notice
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Test timeout of 45000ms exceeded.
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Error: expect(locator).toContainText(expected) Locator: locator('dl dd') - Expected - 3 + Received + 3 Array [ - "COMPLETED", - "READY TO START", - "CANNOT START YET", + " The status of this section of the application is:READY TO CONTINUE ", + " The status of this section of the application is:CANNOT START YET ", + " The status of this section of the application is:CANNOT START YET ", ] Call log: - expect.toContainText with timeout 45000ms - waiting for locator('dl dd') - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements at globalHelpers.ts:235 233 | const pageStatuses = page.locator("dl dd"); 234 | await expect(pageSections).toContainText(sections.map((s) => s.title)); > 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status)); | ^ 236 | } 237 | 238 | export async function fillGovUkCardDetails({ at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30) at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 45000ms exceeded.
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(locator).toContainText(expected) Locator: locator('dl dd') - Expected - 3 + Received + 3 Array [ - "COMPLETED", - "READY TO START", - "CANNOT START YET", + " The status of this section of the application is:READY TO CONTINUE ", + " The status of this section of the application is:CANNOT START YET ", + " The status of this section of the application is:CANNOT START YET ", ] Call log: - expect.toContainText with timeout 45000ms - waiting for locator('dl dd') - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements at globalHelpers.ts:235 233 | const pageStatuses = page.locator("dl dd"); 234 | await expect(pageSections).toContainText(sections.map((s) => s.title)); > 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status)); | ^ 236 | } 237 | 238 | export async function fillGovUkCardDetails({ at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30) at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/sections.spec.ts#L1
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 45000ms exceeded.
[chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started: e2e/tests/ui-driven/src/globalHelpers.ts#L235
1) [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(locator).toContainText(expected) Locator: locator('dl dd') - Expected - 3 + Received + 3 Array [ - "COMPLETED", - "READY TO START", - "CANNOT START YET", + " The status of this section of the application is:READY TO CONTINUE ", + " The status of this section of the application is:CANNOT START YET ", + " The status of this section of the application is:CANNOT START YET ", ] Call log: - expect.toContainText with timeout 45000ms - waiting for locator('dl dd') - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements - locator resolved to 3 elements at globalHelpers.ts:235 233 | const pageStatuses = page.locator("dl dd"); 234 | await expect(pageSections).toContainText(sections.map((s) => s.title)); > 235 | await expect(pageStatuses).toContainText(sections.map((s) => s.status)); | ^ 236 | } 237 | 238 | export async function fillGovUkCardDetails({ at expectSections (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:235:30) at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/sections.spec.ts:367:7
E2E tests
Process completed with exit code 1.
Check file changes
The following actions uses Node.js version which is deprecated and will be forced to run on node20: dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run Integration tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run React Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: andstor/file-existence-action@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
E2E tests: e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts#L93
Unexpected use of networkidle
E2E tests: e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L87
Unexpected use of networkidle
E2E tests: e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L96
Unexpected use of networkidle
E2E tests: e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L131
Unexpected use of networkidle
Slow Test: e2e/tests/ui-driven/[chromium] › sections.spec.ts#L1
e2e/tests/ui-driven/[chromium] › sections.spec.ts took 2.4m
🎭 Playwright Run Summary
1 failed [chromium] › sections.spec.ts:314:9 › Section statuses › simple save and return › not started, ready to start and complete statuses 18 passed (3.3m)

Artifacts

Produced during runtime
Name Size
playwright-report Expired
4.56 MB