chore: Bump planx-core, update types (#2339)

* chore: Bump planx-core * fix: Tighten types to match planx-core changes * chore: Bump planx-core for new tsconfigs * chore: Bump planx-core after merge to main
theopensystemslab · Oct 26, 2023 · 06ad2d8 · 06ad2d8
1 parent caf3fb9
commit 06ad2d8
Show file tree

Hide file tree

Showing 12 changed files with 216 additions and 157 deletions.
diff --git a/api.planx.uk/admin/session/html.ts b/api.planx.uk/admin/session/html.ts
@@ -24,8 +24,9 @@ export const getHTMLExport: HTMLExportHandler = async (req, res, next) => {
     if (!session) throw Error(`Unable to find session ${req.params.sessionId}`);
 
     const responses = await $api.export.csvData(req.params.sessionId);
-    const boundingBox =
-      session.data.passport.data["property.boundary.site.buffered"];
+    const boundingBox = session.data.passport.data[
+      "property.boundary.site.buffered"
+    ] as unknown as GeoJSON.Feature;
 
     const html = generateApplicationHTML({
       planXExportData: responses as PlanXExportData[],
@@ -66,8 +67,9 @@ export const getRedactedHTMLExport: HTMLExportHandler = async (
     const redactedResponses = await $api.export.csvDataRedacted(
       req.params.sessionId,
     );
-    const boundingBox =
-      session.data.passport.data["property.boundary.site.buffered"];
+    const boundingBox = session.data.passport.data[
+      "property.boundary.site.buffered"
+    ] as unknown as GeoJSON.Feature;
 
     const html = generateApplicationHTML({
       planXExportData: redactedResponses as PlanXExportData[],

diff --git a/api.planx.uk/inviteToPay/createPaymentSendEvents.ts b/api.planx.uk/inviteToPay/createPaymentSendEvents.ts
@@ -88,9 +88,11 @@ const createPaymentSendEvents = async (
     if (destinations.includes(Destination.Uniform)) {
       // Bucks has 3 instances of Uniform for 4 legacy councils, set teamSlug to pre-merger council name
       if (teamSlug === "buckinghamshire") {
-        teamSlug = session.data?.passport?.data?.[
+        const localAuthorities: string[] = session.data?.passport?.data?.[
           "property.localAuthorityDistrict"
-        ]
+        ] as string[];
+
+        teamSlug = localAuthorities
           ?.filter((name: string) => name !== "Buckinghamshire")[0]
           ?.toLowerCase()
           ?.replace(/\W+/g, "-");

diff --git a/api.planx.uk/package.json b/api.planx.uk/package.json
@@ -4,7 +4,7 @@
   "private": true,
   "dependencies": {
     "@airbrake/node": "^2.1.8",
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#2b7fa5b",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#69c797c",
     "@types/isomorphic-fetch": "^0.0.36",
     "adm-zip": "^0.5.10",
     "aws-sdk": "^2.1467.0",

diff --git a/api.planx.uk/pnpm-lock.yaml b/api.planx.uk/pnpm-lock.yaml
diff --git a/e2e/tests/api-driven/package.json b/e2e/tests/api-driven/package.json
@@ -6,7 +6,7 @@
   },
   "dependencies": {
     "@cucumber/cucumber": "^9.3.0",
-    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#2b7fa5b",
+    "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#69c797c",
     "axios": "^1.4.0",
     "dotenv": "^16.3.1",
     "dotenv-expand": "^10.0.0",