refine prop constraints response

e2e/tests/ui-driven/src/mocks/geospatialMocks.ts

@@ -1,6 +1,5 @@
 import { OptionWithDataValues } from "../helpers/types";
 import { Feature, Polygon } from "geojson";
-import propertyConstraintsMetadata from "./propertyConstraintMetadata.json";
 
 type ChangeHandlerProperties = {
   label: string;
@@ -66,149 +65,6 @@ export const mockChangedMapGeoJson: GeoJsonChangeHandler = {
   },
 };
 
-export const mockPropertyConstraints = {
-  sourceRequest:
-    "https://www.planning.data.gov.uk/entity.json?entries=current&geometry=POINT%28-0.1151501+51.4745098%29&geometry_relation=intersects&exclude_field=geometry%2Cpoint&limit=100&dataset=article-4-direction-area&dataset=central-activities-zone&dataset=brownfield-land&dataset=brownfield-site&dataset=area-of-outstanding-natural-beauty&dataset=green-belt&dataset=national-park&dataset=world-heritage-site&dataset=world-heritage-site-buffer-zone&dataset=flood-risk-zone&dataset=listed-building&dataset=listed-building-outline&dataset=scheduled-monument&dataset=ancient-woodland&dataset=ramsar&dataset=special-area-of-conservation&dataset=special-protection-area&dataset=site-of-special-scientific-interest&dataset=park-and-garden&dataset=tree&dataset=tree-preservation-order&dataset=tree-preservation-zone",
-  constraints: {
-    listed: {
-      fn: "listed",
-      value: true,
-      text: "is, or is within, a Listed Building",
-      data: [
-        {
-          "entry-date": "2024-04-16",
-          "start-date": "1980-05-15",
-          "end-date": "",
-          entity: 42103309,
-          name: "No Address Supplied",
-          dataset: "listed-building-outline",
-          typology: "geography",
-          reference: "12/435 and 963/1",
-          prefix: "listed-building-outline",
-          "organisation-entity": "192",
-        },
-      ],
-      category: "Heritage and conservation",
-    },
-    article4: {
-      fn: "article4",
-      value: false,
-      text: "is not in an Article 4 direction area",
-      category: "General policy",
-    },
-    "article4.caz": {
-      fn: "article4.caz",
-      value: false,
-      text: "is not in the Central Activities Zone",
-      category: "General policy",
-    },
-    brownfieldSite: {
-      fn: "brownfieldSite",
-      value: false,
-      text: "is not on Brownfield land",
-      category: "General policy",
-    },
-    "designated.AONB": {
-      fn: "designated.AONB",
-      value: false,
-      text: "is not in an Area of Outstanding Natural Beauty",
-      category: "Heritage and conservation",
-    },
-    greenBelt: {
-      fn: "greenBelt",
-      value: false,
-      text: "is not in a Green Belt",
-      category: "General policy",
-    },
-    "designated.nationalPark": {
-      fn: "designated.nationalPark",
-      value: false,
-      text: "is not in a National Park",
-      category: "Heritage and conservation",
-    },
-    "designated.nationalPark.broads": {
-      fn: "designated.nationalPark.broads",
-      value: false,
-    },
-    "designated.WHS": {
-      fn: "designated.WHS",
-      value: false,
-      text: "is not an UNESCO World Heritage Site",
-      category: "Heritage and conservation",
-    },
-    flood: {
-      fn: "flood",
-      value: false,
-      text: "is not in a Flood Risk Zone",
-      category: "Flooding",
-    },
-    monument: {
-      fn: "monument",
-      value: false,
-      text: "is not the site of a Scheduled Monument",
-      category: "Heritage and conservation",
-    },
-    "nature.ASNW": {
-      fn: "nature.ASNW",
-      value: false,
-      text: "is not in an Ancient Semi-Natural Woodland (ASNW)",
-      category: "Ecology",
-    },
-    "nature.ramsarSite": {
-      fn: "nature.ramsarSite",
-      value: false,
-      text: "is not in a Ramsar Site",
-      category: "Ecology",
-    },
-    "nature.SAC": {
-      fn: "nature.SAC",
-      value: false,
-      text: "is not in a Special Area of Conservation (SAC)",
-      category: "Ecology",
-    },
-    "nature.SPA": {
-      fn: "nature.SPA",
-      value: false,
-      text: "is not in a Special Protection Area (SPA)",
-      category: "Ecology",
-    },
-    "nature.SSSI": {
-      fn: "nature.SSSI",
-      value: false,
-      text: "is not a Site of Special Scientific Interest (SSSI)",
-      category: "Ecology",
-    },
-    registeredPark: {
-      fn: "registeredPark",
-      value: false,
-      text: "is not in a Historic Park or Garden",
-      category: "Heritage and conservation",
-    },
-    tpo: {
-      fn: "tpo",
-      value: false,
-      text: "is not in a Tree Preservation Order (TPO) Zone",
-      category: "Trees",
-    },
-    designated: {
-      value: true,
-    },
-    "listed.grade.I": {
-      fn: "listed.grade.I",
-      value: false,
-    },
-    "listed.grade.II": {
-      fn: "listed.grade.II",
-      value: false,
-    },
-    "listed.grade.II*": {
-      fn: "listed.grade.II*",
-      value: false,
-    },
-  },
-  metadata: propertyConstraintsMetadata,
-};
-
 export const mockRoadData = {
   sourceRequest:
     "https://api.os.uk/features/v1/wfs?service=WFS&request=GetFeature&version=2.0.0&typeNames=Highways_RoadLink&outputFormat=GEOJSON&srsName=urn%3Aogc%3Adef%3Acrs%3AEPSG%3A%3A4326&count=1&filter=%0A++++%3Cogc%3AFilter%3E%0A++++++%3Cogc%3APropertyIsLike+wildCard%3D%22%25%22+singleChar%3D%22%23%22+escapeChar%3D%22%21%22%3E%0A++++++++%3Cogc%3APropertyName%3EFormsPartOf%3C%2Fogc%3APropertyName%3E%0A++++++++%3Cogc%3ALiteral%3E%25Street%23usrn21900651%25%3C%2Fogc%3ALiteral%3E%0A++++++%3C%2Fogc%3APropertyIsLike%3E%0A++++%3C%2Fogc%3AFilter%3E%0A++&",

e2e/tests/ui-driven/src/mocks/gisResponse.ts

@@ -1,5 +1,6 @@
 import { expect, Page } from "@playwright/test";
-import { mockPropertyConstraints, mockRoadData } from "./geospatialMocks";
+import { mockRoadData } from "./geospatialMocks";
+import propertyConstraintsResponse from "./propertyConstraintResponse.json";
 
 export async function setupGISMockResponse(page: Page) {
   const gisDigitalLandEndpoint = "**/gis/E2E?geom*";
@@ -8,7 +9,7 @@ export async function setupGISMockResponse(page: Page) {
     expect(urlContainsConstraints).toEqual(true);
     await route.fulfill({
       status: 200,
-      body: JSON.stringify(mockPropertyConstraints),
+      body: JSON.stringify(propertyConstraintsResponse),
     });
   });
 }