feat: export metabase client with delayed instantiation for test

theopensystemslab · Nov 28, 2024 · 301f7d5 · 301f7d5
1 parent b3947be
commit 301f7d5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/api.planx.uk/modules/analytics/metabase/shared/client.test.ts b/api.planx.uk/modules/analytics/metabase/shared/client.test.ts
@@ -3,6 +3,7 @@ import {
   validateConfig,
   createMetabaseClient,
   MetabaseError,
+  initializeMetabaseClient,
 } from "./client.js";
 import nock from "nock";
 
@@ -12,6 +13,9 @@ describe("Metabase client", () => {
   beforeEach(() => {
     vi.clearAllMocks();
     vi.resetModules();
+    process.env.METABASE_URL_EXT = "https://test-metabase-url.com";
+    process.env.METABASE_API_KEY = "test-api-key";
+    initializeMetabaseClient();
   });
 
   afterEach(() => {

diff --git a/api.planx.uk/modules/analytics/metabase/shared/client.ts b/api.planx.uk/modules/analytics/metabase/shared/client.ts
@@ -120,7 +120,10 @@ export const createMetabaseClient = (): AxiosInstance => {
   return client;
 };
 
-// Export singleton instance
-export const metabaseClient = createMetabaseClient();
+// Export both client and instance with delayed instantiation for test purposes
+export let metabaseClient: AxiosInstance;
 
-export default metabaseClient;
+export const initializeMetabaseClient = () => {
+  metabaseClient = createMetabaseClient();
+  return metabaseClient;
+};