wip

theopensystemslab · Apr 16, 2024 · 45eb2a5 · 45eb2a5
1 parent 252f1fb
commit 45eb2a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/editor.planx.uk/src/@planx/components/FindProperty/Public/Autocomplete.tsx b/editor.planx.uk/src/@planx/components/FindProperty/Public/Autocomplete.tsx
@@ -27,7 +27,6 @@ interface PickOSAddressProps {
   setShowPostcodeError: React.Dispatch<React.SetStateAction<boolean>>;
   initialSelectedAddress?: Option;
   showAddressSelectError: boolean;
-  setShowAddressSelectError: React.Dispatch<React.SetStateAction<boolean>>;
   id?: string;
   description?: string;
 }
@@ -55,7 +54,7 @@ export default function PickOSAddress(props: PickOSAddressProps): FCReturn {
   );
   const [sanitizedPostcode, setSanitizedPostcode] = useState<string | null>(
     (props.initialPostcode && toNormalised(props.initialPostcode.trim())) ??
-    null,
+      null,
   );
   const [selectedOption, setSelectedOption] = useState<Option | undefined>(
     props.initialSelectedAddress ?? undefined,
@@ -187,7 +186,7 @@ export default function PickOSAddress(props: PickOSAddressProps): FCReturn {
         />
       </InputLabel>
       {sanitizedPostcode && (
-        <ErrorWrapperRoot error={props.showAddressSelectError ? "Select an address to continue" : undefined} role="alert" data-testid="autocomplete-error-wrapper">
+        <ErrorWrapperRoot error={!selectedOption && props.showAddressSelectError ? "Select an address to continue" : undefined} role="alert" data-testid="autocomplete-error-wrapper">
           {/* @ts-ignore */
             <address-autocomplete
               id="address-autocomplete"

diff --git a/editor.planx.uk/src/@planx/components/FindProperty/Public/index.tsx b/editor.planx.uk/src/@planx/components/FindProperty/Public/index.tsx
@@ -174,7 +174,6 @@ function Component(props: Props) {
               previouslySubmittedData?._address
             }
             showAddressSelectError={showAddressSelectError}
-            setShowAddressSelectError={setShowAddressSelectError}
             id={props.id}
             description={props.description || ""}
           />
@@ -214,12 +213,12 @@ function Component(props: Props) {
       handleSubmit={() => {
         // Handle validation (eventually formalise with yup schema?)
         if (page === "os-address") {
-          if (!address?.postcode) {
-            setShowPostcodeError(true);
-            return;
-          } else if (!address?.title) {
+          if (showPostcodeError && !address) {
             setShowAddressSelectError(true);
             return;
+          } else if (!address) {
+            setShowPostcodeError(true);
+            return;
           } else if (!localAuthorityDistricts) {
             setShowDataFetchingError(true);
             return;