Expose feedbackScore separately

theopensystemslab · Nov 14, 2024 · 55ef0bd · 55ef0bd
1 parent 6896569
commit 55ef0bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/api.planx.uk/modules/webhooks/service/analyzeSessions/operations.ts b/api.planx.uk/modules/webhooks/service/analyzeSessions/operations.ts
@@ -22,6 +22,7 @@ const ALLOW_LIST = [
   "application.type",
   "drawBoundary.action",
   "_feedback",
+  "_feedback.feedbackScore",
   "findProperty.action",
   "_overrides",
   "planningConstraints.action",
@@ -63,7 +64,7 @@ export const trackAllowListAnswers: Operation = async () => {
 
     const id = await updateLowcalSessionAllowListAnswers(
       sessionId,
-      allowListAnswers,
+      allowListAnswers
     );
     if (id) updatedSessionIds.push(id);
   }
@@ -103,7 +104,7 @@ export const getSubmittedUnAnalyzedSessionIds = async (): Promise<string[]> => {
  */
 export const updateLowcalSessionAllowListAnswers = async (
   sessionId: string,
-  allowListAnswers: Passport["data"],
+  allowListAnswers: Passport["data"]
 ): Promise<string> => {
   try {
     const mutation = gql`
@@ -126,7 +127,7 @@ export const updateLowcalSessionAllowListAnswers = async (
     return id;
   } catch (error) {
     throw new Error(
-      `Error updating allow_list_answers for lowcal_session ${sessionId}`,
+      `Error updating allow_list_answers for lowcal_session ${sessionId}`
     );
   }
 };
diff --git a/editor.planx.uk/src/pages/FlowEditor/lib/analytics/provider.tsx b/editor.planx.uk/src/pages/FlowEditor/lib/analytics/provider.tsx
@@ -50,6 +50,7 @@ export const ALLOW_LIST = [
   "application.type",
   "drawBoundary.action",
   PASSPORT_FEEDBACK_KEY,
+  "_feedback.feedbackScore",
   "findProperty.action",
   "_overrides",
   "planningConstraints.action",

diff --git a/hasura.planx.uk/migrations/1731498724636_run_sql_migration/up.sql b/hasura.planx.uk/migrations/1731498724636_run_sql_migration/up.sql
@@ -49,7 +49,8 @@ CREATE OR REPLACE VIEW "public"."analytics_summary" AS
     ((al.allow_list_answers -> 'application.information.harmful'::text))::text AS pre_app_harmful_info,
     ((al.allow_list_answers -> 'application.information.sensitive'::text))::text AS pre_app_sensitive_info,
     (((al.allow_list_answers -> 'application.type'::text) -> 0))::text AS application_type,
-    ((al.allow_list_answers -> '_feedback'::text))::text AS feedback
+    ((al.allow_list_answers -> '_feedback'::text))::text AS feedback,
+    ((al.allow_list_answers -> '_feedback' ->> 'feedbackScore')::text) AS feedback_score
    FROM (((analytics a
      LEFT JOIN analytics_logs al ON ((a.id = al.analytics_id)))
      LEFT JOIN flows f ON ((a.flow_id = f.id)))
@@ -143,7 +144,8 @@ CREATE OR REPLACE VIEW "public"."submission_services_summary" AS
     ((ls.allow_list_answers -> 'application.information.harmful'::text))::text AS pre_app_harmful_info,
     ((ls.allow_list_answers -> 'application.information.sensitive'::text))::text AS pre_app_sensitive_info,
     (((ls.allow_list_answers -> 'application.type'::text) -> 0))::text AS application_type,
-    ((ls.allow_list_answers -> '_feedback'::text))::text AS feedback
+    ((ls.allow_list_answers -> '_feedback'::text))::text AS feedback,
+    ((ls.allow_list_answers -> '_feedback' ->> 'feedbackScore')::text) AS feedback_score
    FROM (((((((((lowcal_sessions ls
      LEFT JOIN flows f ON ((f.id = ls.flow_id)))
      LEFT JOIN teams t ON ((t.id = f.team_id)))