fix: Change first-child to first-of-type

theopensystemslab · Jan 17, 2024 · 588dbec · 588dbec
1 parent 9abbe36
commit 588dbec
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/editor.planx.uk/src/@planx/components/Content/Public.tsx b/editor.planx.uk/src/@planx/components/Content/Public.tsx
@@ -22,7 +22,7 @@ const Content = styled(Box, {
   "& a": {
     color: getContrastTextColor(color || "#fff", theme.palette.primary.main),
   },
-  "& *:first-child": {
+  "& *:first-of-type": {
     marginTop: 0,
   },
 }));

diff --git a/editor.planx.uk/src/pages/FlowEditor/floweditor.scss b/editor.planx.uk/src/pages/FlowEditor/floweditor.scss
@@ -171,7 +171,7 @@ $pixel: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAA
       opacity: 0.3;
     }
 
-    > span:not(:first-child) {
+    > span:not(:first-of-type) {
       margin-left: 6px;
     }
   }
@@ -352,7 +352,7 @@ $pixel: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAA
           $lineWidth;
         background-repeat: no-repeat, repeat-x, repeat-x;
 
-        &:first-child {
+        &:first-of-type {
           background-position:
             top center,
             top right,
@@ -392,7 +392,7 @@ $pixel: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAA
           $lineWidth 100%,
           1px 100%;
 
-        &:first-child {
+        &:first-of-type {
           background-position:
             left center,
             left bottom,

diff --git a/editor.planx.uk/src/ui/editor/RichTextInput.tsx b/editor.planx.uk/src/ui/editor/RichTextInput.tsx
@@ -97,7 +97,7 @@ export const RichContentContainer = styled(Box)(({ theme }) => ({
       },
     },
     // Styles for placeholder text, to match ui/Input.tsx
-    "& p.is-editor-empty:first-child::before": {
+    "& p.is-editor-empty:first-of-type::before": {
       color: theme.palette.text.secondary,
       opacity: "0.5",
       content: `attr(data-placeholder)`,

diff --git a/editor.planx.uk/src/ui/shared/InputRow.tsx b/editor.planx.uk/src/ui/shared/InputRow.tsx
@@ -14,7 +14,7 @@ const Root = styled(Box, {
     flexGrow: 1,
     marginLeft: 1,
     marginRight: 5,
-    "&:first-child": {
+    "&:first-of-type": {
       marginLeft: 0,
     },
     "&:last-child": {

diff --git a/editor.planx.uk/src/ui/shared/InputRowLabel.tsx b/editor.planx.uk/src/ui/shared/InputRowLabel.tsx
@@ -7,7 +7,7 @@ const Label = styled(Typography)(({ theme }) => ({
   flexGrow: 0,
   paddingRight: theme.spacing(2),
   alignSelf: "center",
-  "&:not(:first-child)": {
+  "&:not(*:first-of-type)": {
     paddingLeft: theme.spacing(2),
   },
 })) as typeof Typography;