chore: Stream S3 files directly to zip (take 2) (#2495)

* chore: Stream S3 files directly to zip (#2380) * fix: Remove /tmp prefix in zip files
theopensystemslab · Dec 11, 2023 · 751d1dd · 751d1dd
1 parent 27c18ad
commit 751d1dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/api.planx.uk/modules/send/utils/exportZip.test.ts b/api.planx.uk/modules/send/utils/exportZip.test.ts
@@ -7,7 +7,6 @@ jest.mock("fs", () => ({
   existsSync: () => true,
   unlinkSync: () => undefined,
   createWriteStream: () => undefined,
-  writeFileSync: () => undefined,
   rmSync: () => undefined,
 }));
 

diff --git a/api.planx.uk/modules/send/utils/exportZip.ts b/api.planx.uk/modules/send/utils/exportZip.ts
@@ -193,13 +193,9 @@ export class ExportZip {
     const s3Key = url.split("/").slice(-2).join("/");
     const decodedS3Key = decodeURIComponent(s3Key);
     const { body } = await getFileFromS3(decodedS3Key);
-    if (!body) {
-      throw new Error("file not found");
-    }
-    const filePath = path.join(this.tmpDir, name);
-    fs.writeFileSync(filePath, body as Buffer);
-    this.zip.addLocalFile(filePath);
-    fs.unlinkSync(filePath);
+    if (!body) throw new Error("file not found");
+
+    this.zip.addFile(name, body as Buffer);
   }
 
   toBuffer(): Buffer {