revert filter tests written in geospatial

theopensystemslab · Dec 3, 2024 · a73c2cd · a73c2cd
1 parent 89c4ad8
commit a73c2cd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts b/e2e/tests/ui-driven/src/create-flow-with-geospatial.spec.ts
@@ -51,7 +51,6 @@ test.describe("Flow creation, publish and preview", () => {
     await editor.createInternalPortal();
     await editor.populateInternalPortal();
     await page.getByRole("link", { name: "start" }).click(); // return to main flow
-    await editor.createFilter();
     await editor.createUploadAndLabel();
     // TODO: editor.createPropertyInfo()
     await editor.createDrawBoundary();
@@ -61,7 +60,6 @@ test.describe("Flow creation, publish and preview", () => {
     await expect(editor.nodeList).toContainText([
       "Find property",
       "an internal portalEdit Portal",
-      "Filter - Planning permissionImmuneMissing informationPermission neededPrior approvalNoticePermitted developmentNot developmentNo flag result",
       "Upload and label",
       "Confirm your location plan",
       "Planning constraints",
@@ -110,7 +108,6 @@ test.describe("Flow creation, publish and preview", () => {
     ).toBeVisible();
     await clickContinue({ page });
 
-    // TODO: answer filter?
     // TODO: answer uploadAndLabel
     // TODO: answerPropertyInfo, answerDrawBoundary, answerPlanningConstraints
   });

diff --git a/e2e/tests/ui-driven/src/pages/Editor.ts b/e2e/tests/ui-driven/src/pages/Editor.ts
@@ -224,14 +224,15 @@ export class PlaywrightEditor {
   async createFilter() {
     await createFilter(this.page, this.getNextNode());
     // select the branch filter and add some content
-    const permissionNeededNode = this.page
+    const filteredBranch = this.page
       .locator("li")
       .filter({ hasText: /Material change of use$/ })
       .getByRole("listitem")
       .getByRole("link");
+
     await createContent(
       this.page,
-      permissionNeededNode,
+      filteredBranch,
       `This is the ${selectedFlag} filter`,
     );
   }