Change feedback field to userComment

theopensystemslab · Nov 11, 2024 · aa19903 · aa19903
1 parent 0aba609
commit aa19903
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 18 deletions.
diff --git a/editor.planx.uk/src/@planx/components/Feedback/Public/Feedback.stories.tsx b/editor.planx.uk/src/@planx/components/Feedback/Public/Feedback.stories.tsx
@@ -13,12 +13,5 @@ type Story = StoryObj<typeof meta>;
 export default meta;
 
 export const Basic = {
-  args: {
-    title: defaultContent.title,
-    feedbackRequired: false,
-    description: defaultContent.description,
-    freeformQuestion: defaultContent.freeformQuestion,
-    ratingQuestion: defaultContent.ratingQuestion,
-    disclaimer: defaultContent.disclaimer,
-  },
+  args: defaultContent,
 } satisfies Story;
diff --git a/editor.planx.uk/src/@planx/components/Feedback/Public/Public.tsx b/editor.planx.uk/src/@planx/components/Feedback/Public/Public.tsx
@@ -30,13 +30,9 @@ export const PASSPORT_FEEDBACK_KEY = "_feedback";
 const FeedbackComponent = (props: PublicProps<Feedback>): FCReturn => {
   const handleSubmitFeedback = async (values: FormProps) => {
     const metadata = await getInternalFeedbackMetadata();
-    const feedback = {
-      userComment: values.feedback,
-      feedbackScore: values.feedbackScore,
-    };
     const data = {
       ...metadata,
-      ...feedback,
+      ...values,
       feedbackType: "component" as FeedbackView,
     };
     const submitFeedbackResult = await insertFeedbackMutation(data).catch(
@@ -53,7 +49,7 @@ const FeedbackComponent = (props: PublicProps<Feedback>): FCReturn => {
   const formik = useFormik<FormProps>({
     initialValues: getPreviouslySubmittedData(props) ?? {
       feedbackScore: "",
-      feedback: "",
+      userComment: "",
     },
     onSubmit: handleSubmitFeedback,
   });
@@ -152,11 +148,11 @@ const FeedbackComponent = (props: PublicProps<Feedback>): FCReturn => {
         <Input
           multiline={true}
           rows={3}
-          name="feedback"
-          value={formik.values.feedback}
+          name="userComment"
+          value={formik.values.userComment}
           bordered
           onChange={formik.handleChange}
-          aria-label="feedback"
+          aria-label="user comment"
         />
       </Box>
       {props.disclaimer && <Disclaimer text={props.disclaimer} />}

diff --git a/editor.planx.uk/src/@planx/components/Feedback/model.ts b/editor.planx.uk/src/@planx/components/Feedback/model.ts
@@ -10,7 +10,7 @@ export interface Feedback extends BaseNodeData {
 }
 export interface FormProps {
   feedbackScore: string;
-  feedback: string;
+  userComment: string;
 }
 
 export const parseFeedback = (