Skip to content

Commit

Permalink
chore: remove feature flag for feedback component (#3983)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamdelion authored Nov 20, 2024
1 parent be24a07 commit b1a76f8
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 16 deletions.
5 changes: 5 additions & 0 deletions doc/how-to/how-to-setup-custom-subdomains.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,9 @@ This guide will walk through the process of setting a custom domain for a new te
11. **PlanX** - Add custom domain to UptimeRobot (create monitor & also select SSL reminders)
> [!NOTE]
> We do not have individual named logins for our UptimeRobot account. Instead we have one single shared one in the 1Password "root/admin" vault, which not everyone will have access to.
>
> Therefore you might need to ask someone to do this step for you if you do not have access.
12. **PlanX** - Add certificate expiry date to [PlanX CMS on Notion](https://www.notion.so/opensystemslab/Plan-Customers-dee2cdfb40c04b5fa88edc5a86989211)
2 changes: 1 addition & 1 deletion editor.planx.uk/src/lib/featureFlags.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// add/edit/remove feature flags in array below
const AVAILABLE_FEATURE_FLAGS = ["FEEDBACK_COMPONENT"] as const;
const AVAILABLE_FEATURE_FLAGS = [] as const;

type FeatureFlag = (typeof AVAILABLE_FEATURE_FLAGS)[number];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const feedbackTypeIcon = (type: FeedbackType): FeedbackTypeIcon => {
title: "Unhelpful (help text)",
};
case "component":
return { icon: <RateReviewIcon />, title: "From feedback component" };
return { icon: <RateReviewIcon />, title: "User satisfaction" };
default:
return { icon: <RuleIcon />, title: "Inaccuracy" };
}
Expand Down Expand Up @@ -126,16 +126,15 @@ export const CollapsibleRow: React.FC<CollapsibleRowProps> = (item) => {
userContext: "What were you doing?",
};

enum EmojiRating {
Terrible,
Poor,
Average,
Good,
Excellent,
}
const EmojiRating: Record<number, string> = {
1: "Terrible",
2: "Poor",
3: "Neutral",
4: "Good",
5: "Excellent",
};

const feedbackScore =
item.feedbackScore && EmojiRating[item.feedbackScore + 1]; // enums are 0-indexed
const feedbackScore = EmojiRating[item.feedbackScore];

const renderContent = (key: string, value: any) => {
if (key === "combinedHelp" && value) {
Expand All @@ -155,7 +154,7 @@ export const CollapsibleRow: React.FC<CollapsibleRowProps> = (item) => {
<TableCell>
{format(new Date(item.createdAt), "dd/MM/yy hh:mm:ss")}
</TableCell>
<TableCell sx={{ textAlign: "center" }}>{feedbackScore}</TableCell>
<TableCell>{feedbackScore}</TableCell>
<TableCell>{commentSummary}</TableCell>
<TableCell sx={{ textAlign: "right" }}>
<IconButton
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { styled } from "@mui/material/styles";
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";
import { parseFormValues } from "@planx/components/shared";
import ErrorFallback from "components/Error/ErrorFallback";
import { hasFeatureFlag } from "lib/featureFlags";
import React from "react";
import { ErrorBoundary } from "react-error-boundary";
import { useNavigation } from "react-navi";
Expand Down Expand Up @@ -64,9 +63,7 @@ const NodeTypeSelect: React.FC<{
<option value={TYPES.List}>List</option>
<option value={TYPES.Page}>Page</option>
<option value={TYPES.MapAndLabel}>Map and Label (Testing only)</option>
{hasFeatureFlag("FEEDBACK_COMPONENT") && (
<option value={TYPES.Feedback}>Feedback (Testing only)</option>
)}
<option value={TYPES.Feedback}>Feedback</option>
</optgroup>
<optgroup label="Information">
<option value={TYPES.TaskList}>Task List</option>
Expand Down

0 comments on commit b1a76f8

Please sign in to comment.