refactor: rename metabase_link to analytics_link

- As per: #2387 (comment)
- Best practice not to tie the variable name to a single provider

editor.planx.uk/src/pages/FlowEditor/components/PreviewBrowser.tsx

@@ -99,15 +99,15 @@ const PreviewBrowser: React.FC<{
   const [showDebugConsole, setDebugConsoleVisibility] = useState(false);
   const [
     flowId,
-    flowMetabaseLink,
+    flowAnalyticsLink,
     resetPreview,
     publishFlow,
     lastPublished,
     lastPublisher,
     validateAndDiffFlow,
   ] = useStore((state) => [
     state.id,
-    state.flowMetabaseLink,
+    state.flowAnalyticsLink,
     state.resetPreview,
     state.publishFlow,
     state.lastPublished,
@@ -160,10 +160,10 @@ const PreviewBrowser: React.FC<{
             />
           </Tooltip>
 
-          {flowMetabaseLink ? (
+          {flowAnalyticsLink ? (
             <Tooltip arrow title="Open analytics page">
               <Link
-                href={flowMetabaseLink}
+                href={flowAnalyticsLink}
                 target="_blank"
                 rel="noopener noreferrer"
                 color="inherit"

editor.planx.uk/src/pages/FlowEditor/lib/store/shared.ts

@@ -13,7 +13,7 @@ export interface SharedStore extends Store.Store {
   flow: Store.flow;
   flowSlug: string;
   flowName: string;
-  flowMetabaseLink: string | null;
+  flowAnalyticsLink: string | null;
   id: string;
   getNode: (id: Store.nodeId) => Store.node | undefined;
   resetPreview: () => void;
@@ -52,7 +52,7 @@ export const sharedStore: StateCreator<
 
   flowName: "",
 
-  flowMetabaseLink: null,
+  flowAnalyticsLink: null,
 
   id: "",
   previewEnvironment: "standalone",

editor.planx.uk/src/routes/flow.tsx

@@ -176,7 +176,7 @@ const nodeRoutes = mount({
 const getFlowMetadata = async (
   flow: string,
   team: string,
-): Promise<{ flowSettings: FlowSettings; flowMetabaseLink: string }> => {
+): Promise<{ flowSettings: FlowSettings; flowAnalyticsLink: string }> => {
   const { data } = await client.query({
     query: gql`
       query GetFlow($slug: String!, $team_slug: String!) {
@@ -186,7 +186,7 @@ const getFlowMetadata = async (
         ) {
           id
           flowSettings: settings
-          flowMetabaseLink: metabase_link
+          flowAnalyticsLink: analytics_link
         }
       }
     `,
@@ -197,7 +197,7 @@ const getFlowMetadata = async (
   });
   const metadata = {
     flowSettings: data.flows[0]?.flowSettings,
-    flowMetabaseLink: data.flows[0]?.flowMetabaseLink,
+    flowAnalyticsLink: data.flows[0]?.flowAnalyticsLink,
   };
   return metadata;
 };
@@ -209,11 +209,11 @@ const routes = compose(
 
   withView(async (req) => {
     const [flow, ...breadcrumbs] = req.params.flow.split(",");
-    const { flowSettings, flowMetabaseLink } = await getFlowMetadata(
+    const { flowSettings, flowAnalyticsLink } = await getFlowMetadata(
       flow,
       req.params.team,
     );
-    useStore.setState({ flowSettings, flowMetabaseLink });
+    useStore.setState({ flowSettings, flowAnalyticsLink });
 
     return (
       <>

hasura.planx.uk/metadata/tables.yaml

@@ -347,7 +347,7 @@
           - creator_id
           - data
           - id
-          - metabase_link
+          - analytics_link
           - settings
           - slug
           - team_id
@@ -378,7 +378,7 @@
           - creator_id
           - data
           - id
-          - metabase_link
+          - analytics_link
           - settings
           - slug
           - team_id

hasura.planx.uk/migrations/1699371548814_alter_table_public_flows_alter_column_metabase_link/down.sql

@@ -0,0 +1 @@
+alter table "public"."flows" rename column "analytics_link" to "metabase_link";

hasura.planx.uk/migrations/1699371548814_alter_table_public_flows_alter_column_metabase_link/up.sql

@@ -0,0 +1 @@
+alter table "public"."flows" rename column "metabase_link" to "analytics_link";