feat: Handle max errors

theopensystemslab · Aug 29, 2024 · b9ea5d3 · b9ea5d3
1 parent fa1364f
commit b9ea5d3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/editor.planx.uk/src/@planx/components/MapAndLabel/Public/Context.tsx b/editor.planx.uk/src/@planx/components/MapAndLabel/Public/Context.tsx
@@ -132,6 +132,11 @@ export const MapAndLabelProvider: React.FC<MapAndLabelProviderProps> = (
     const currentFeatures = formik.values.schemaData;
     const updatedFeatures = [...currentFeatures, initialValues];
     formik.setFieldValue("schemaData", updatedFeatures);
+
+    // TODO: Handle more gracefully - stop user from adding new feature to map?
+    if (schema.max && updatedFeatures.length > schema.max) {
+      setMaxError(true);
+    }
   };
 
   return (

diff --git a/editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.tsx b/editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.tsx
@@ -121,7 +121,7 @@ const Root = () => {
   } = mapAndLabelProps;
 
   const [features, setFeatures] = useState<Feature[] | undefined>(undefined);
-  const { addFeature } = useMapAndLabelContext();
+  const { addFeature, schema } = useMapAndLabelContext();
 
   useEffect(() => {
     const geojsonChangeHandler = ({ detail: geojson }: any) => {
@@ -143,6 +143,11 @@ const Root = () => {
     };
   }, [setFeatures, addFeature]);
 
+  const rootError: string =
+    (errors.min && `You must provide at least ${schema.min} response(s)`) ||
+    (errors.max && `You can provide at most ${schema.max} response(s)`) ||
+    "";
+
   return (
     <Card handleSubmit={validateAndSubmitForm} isValid>
       <CardHeader
@@ -153,13 +158,7 @@ const Root = () => {
         howMeasured={howMeasured}
       />
       <FullWidthWrapper>
-        <ErrorWrapper
-          error={
-            errors.min
-              ? "Please add at least one feature to the map"
-              : undefined
-          }
-        >
+        <ErrorWrapper error={rootError}>
           <MapContainer environment="standalone">
             {/* @ts-ignore */}
             <my-map