test: remove unnecessary baseURL variable and check

theopensystemslab · Nov 29, 2024 · c033f24 · c033f24
1 parent ee49ce2
commit c033f24
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/api.planx.uk/modules/analytics/metabase/shared/client.test.ts b/api.planx.uk/modules/analytics/metabase/shared/client.test.ts
@@ -53,12 +53,7 @@ describe("Metabase client", () => {
 
   describe("Error handling", () => {
     test("retries then succeeds on 5xx errors", async () => {
-      const baseURL = process.env.METABASE_URL_EXT;
-      if (!baseURL) {
-        throw new Error("METABASE_URL_EXT must be defined for tests");
-      }
-
-      const metabaseScope = nock(baseURL);
+      const metabaseScope = nock(process.env.METABASE_URL_EXT!);
 
       metabaseScope
         .get("/test")