refactor: remove redundant waitFor

theopensystemslab · Feb 26, 2024 · c4c57f1 · c4c57f1
1 parent 7a484a5
commit c4c57f1
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/editor.planx.uk/src/components/Feedback/FeedbackForm.test.tsx b/editor.planx.uk/src/components/Feedback/FeedbackForm.test.tsx
@@ -1,4 +1,3 @@
-import { waitFor } from "@testing-library/react";
 import React from "react";
 import { axe, setup } from "testUtils";
 
@@ -75,14 +74,12 @@ describe("FeedbackForm functionality", () => {
     );
     await user.click(getByText("Send feedback"));
 
-    await waitFor(() => {
-      expect(mockHandleSubmit).toHaveBeenCalledWith(
-        expect.objectContaining({
-          userComment: "This is a test comment",
-        }),
-        expect.any(Object),
-      );
-    });
+    expect(mockHandleSubmit).toHaveBeenCalledWith(
+      expect.objectContaining({
+        userComment: "This is a test comment",
+      }),
+      expect.any(Object),
+    );
   });
 
   test("can submit labelled inputs", async () => {
@@ -95,18 +92,15 @@ describe("FeedbackForm functionality", () => {
 
     await user.type(getByLabelText("User Context"), "This is test context");
     await user.type(getByLabelText("User Comment"), "This is a test comment");
-
     await user.click(getByText("Send feedback"));
 
-    await waitFor(() => {
-      expect(mockHandleSubmit).toHaveBeenCalledWith(
-        expect.objectContaining({
-          userContext: "This is test context",
-          userComment: "This is a test comment",
-        }),
-        expect.any(Object),
-      );
-    });
+    expect(mockHandleSubmit).toHaveBeenCalledWith(
+      expect.objectContaining({
+        userContext: "This is test context",
+        userComment: "This is a test comment",
+      }),
+      expect.any(Object),
+    );
   });
 });