Skip to content

Commit

Permalink
test: Remove vanillaStore, instead import useStore
Browse files Browse the repository at this point in the history
  • Loading branch information
DafyddLlyr committed Jul 12, 2024
1 parent 9763d53 commit c738c8f
Show file tree
Hide file tree
Showing 34 changed files with 68 additions and 68 deletions.
4 changes: 2 additions & 2 deletions editor.planx.uk/src/@planx/components/Calculate/logic.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";
import { Store, vanillaStore } from "pages/FlowEditor/lib/store";
import { Store, useStore } from "pages/FlowEditor/lib/store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { upcomingCardIds, resetPreview, record } = getState();

// Helper method
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Breadcrumbs } from "@opensystemslab/planx-core/types";
import { PASSPORT_REQUESTED_FILES_KEY } from "@planx/components/FileUploadAndLabel/model";
import { screen } from "@testing-library/react";
import axios from "axios";
import { vanillaStore } from "pages/FlowEditor/lib/store";
import { useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { act } from "react-dom/test-utils";
import { axe, setup } from "testUtils";
Expand All @@ -18,7 +18,7 @@ jest.mock("axios");
const mockedAxios = axios as jest.Mocked<typeof axios>;
global.URL.createObjectURL = jest.fn();

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

test("recovers previously submitted files when clicking the back button", async () => {
const handleSubmit = jest.fn();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { screen } from "@testing-library/react";
import { vanillaStore } from "pages/FlowEditor/lib/store";
import { useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { DndProvider } from "react-dnd";
import { HTML5Backend } from "react-dnd-html5-backend";
import { setup } from "testUtils";

import FileUploadAndLabelComponent from "./Editor";

const { getState } = vanillaStore;
const { getState } = useStore;

describe("FileUploadAndLabel - Editor Modal", () => {
// TODO correctly mock an authenticated Platform Admin user so 'add new' button is enabled in final test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { act, screen, waitFor, within } from "@testing-library/react";
import { UserEvent } from "@testing-library/user-event/dist/types/setup/setup";
import axios from "axios";
import { vanillaStore } from "pages/FlowEditor/lib/store";
import { useStore } from "pages/FlowEditor/lib/store";
import { FullStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { axe, setup } from "testUtils";
Expand All @@ -11,7 +11,7 @@ import { mockFileTypes, mockFileTypesUniqueKeys } from "./mocks";
import { PASSPORT_REQUESTED_FILES_KEY } from "./model";
import FileUploadAndLabelComponent from "./Public";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
let initialState: FullStore;

jest.mock("axios");
Expand Down
4 changes: 2 additions & 2 deletions editor.planx.uk/src/@planx/components/Pay/Editor.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { User } from "@opensystemslab/planx-core/types";
import { fireEvent, waitFor } from "@testing-library/react";
import { toggleFeatureFlag } from "lib/featureFlags";
import { FullStore, vanillaStore } from "pages/FlowEditor/lib/store";
import { FullStore, useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { DndProvider } from "react-dnd";
import { HTML5Backend } from "react-dnd-html5-backend";
Expand Down Expand Up @@ -35,7 +35,7 @@ describe("Pay component - Editor Modal", () => {
jest.setTimeout(20000);

// Set up mock state with platformAdmin user so all Editor features are enabled
const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const mockUser: User = {
id: 123,
email: "[email protected]",
Expand Down
4 changes: 2 additions & 2 deletions editor.planx.uk/src/@planx/components/Result/Public.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { screen } from "@testing-library/react";
import React from "react";
import { axe, setup } from "testUtils";

import { vanillaStore } from "../../../pages/FlowEditor/lib/store";
import { useStore } from "../../../pages/FlowEditor/lib/store";
import Result from "./Public";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

beforeEach(() => {
getState().resetPreview();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, screen, waitFor, within } from "@testing-library/react";
import { FullStore, vanillaStore } from "pages/FlowEditor/lib/store";
import { FullStore, useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { axe, setup } from "testUtils";

Expand All @@ -25,7 +25,7 @@ import {
import { mockedBreadcrumbs, mockedFlow, mockedPassport } from "./mocks/simple";
import Review from "./Presentational";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

let initialState: FullStore;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import Button from "@mui/material/Button";
import { act, screen, waitFor } from "@testing-library/react";
import { FullStore, vanillaStore } from "pages/FlowEditor/lib/store";
import { FullStore, useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { axe, setup } from "testUtils";
import { ApplicationPath } from "types";

import Card from "./Card";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

let initialState: FullStore;

Expand Down
4 changes: 2 additions & 2 deletions editor.planx.uk/src/components/Feedback/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ import {
getInternalFeedbackMetadata,
insertFeedbackMutation,
} from "lib/feedback";
import { vanillaStore } from "pages/FlowEditor/lib/store";
import { useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { axe, setup } from "testUtils";

import Feedback from "./index";

const { setState } = vanillaStore;
const { setState } = useStore;

const mockedBreadcrumbs: Breadcrumbs = {
LU5xin8PHs: {
Expand Down
4 changes: 2 additions & 2 deletions editor.planx.uk/src/components/Header.test.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Team } from "@opensystemslab/planx-core/types";
import { screen } from "@testing-library/react";
import { vanillaStore } from "pages/FlowEditor/lib/store";
import { useStore } from "pages/FlowEditor/lib/store";
import React from "react";
import { act } from "react-dom/test-utils";
import * as ReactNavi from "react-navi";
Expand All @@ -10,7 +10,7 @@ import flowWithoutSections from "../pages/FlowEditor/lib/__tests__/mocks/flowWit
import flowWithThreeSections from "../pages/FlowEditor/lib/__tests__/mocks/flowWithThreeSections.json";
import Header from "./Header";

const { setState, getState } = vanillaStore;
const { setState, getState } = useStore;

const mockTeam1: Team = {
id: 123,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const flow: Store.flow = {
_root: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";
import shuffle from "lodash/shuffle";

import { vanillaStore } from "../store";
import { useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

beforeEach(() => {
getState().resetPreview();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { vanillaStore } from "../store";
const { getState, setState } = vanillaStore;
import { useStore } from "../store";
const { getState, setState } = useStore;
import forwardsFlow from "./mocks/flowWithClones.json";
import reverseFlow from "./mocks/flowWithReverseClones.json";

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { FullStore, vanillaStore } from "../store";
import { FullStore, useStore } from "../store";
import multipleExternalPortals from "./mocks/multipleExternalPortals.json";
import singleExternalPortal from "./mocks/singleExternalPortal.json";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { upcomingCardIds, record } = getState();

let initialState: FullStore;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { vanillaStore } from "../store";
import { useStore } from "../store";
import flowWithAutoAnsweredFilterPaths from "./mocks/flowWithAutoAnsweredFilterPaths.json";
import flowWithBranchingFilters from "./mocks/flowWithBranchingFilters.json";
import flowWithRootFilter from "./mocks/flowWithRootFilter.json";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const {
upcomingCardIds,
resetPreview,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { vanillaStore } from "../store";
import { useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

describe("in a flow with no collected flags, the user", () => {
beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const flow: Store.flow = {
_root: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { FullStore, vanillaStore } from "../store";
import { FullStore, useStore } from "../store";
import flowWithoutSections from "./mocks/flowWithClones.json";
import flowWithThreeSections from "./mocks/flowWithThreeSections.json";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { filterFlowByType, initNavigationStore, record } = getState();

let initialState: FullStore;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const flow: Store.flow = {
_root: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { Store, vanillaStore } from "../../store";
import { Store, useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { canGoBack, getCurrentCard, resetPreview, record, changeAnswer } =
getState();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import cloneDeep from "lodash/cloneDeep";

import { Store, vanillaStore } from "../../store";
import { Store, useStore } from "../../store";
import flowWithAutoAnswersMock from "../mocks/flowWithAutoAnswers.json";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const flowWithAutoAnswers = cloneDeep(flowWithAutoAnswersMock) as Store.flow;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { vanillaStore } from "../../store";
import { useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { record, hasPaid } = getState();

test("hasPaid is updated if a Pay component has been recorded", () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { vanillaStore } from "../../store";
import { useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const { overrideAnswer, getCurrentCard, upcomingCardIds, record } = getState();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { vanillaStore } from "../../store";
import { useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const { resetPreview, previousCard, getCurrentCard } = getState();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { vanillaStore } from "../../store";
import { useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { record } = getState();

describe("error handling", () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import cloneDeep from "lodash/cloneDeep";

import { Store, vanillaStore } from "../../store";
import { Store, useStore } from "../../store";
import { removeNodesDependentOnPassport } from "../../store/preview";
import breadcrumbsDependentOnPassportMock from "../mocks/breadcrumbsDependentOnPassport.json";
import flowWithPassportComponentsMock from "../mocks/flowWithPassportComponents.json";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

let breadcrumbsDependentOnPassport = cloneDeep(
breadcrumbsDependentOnPassportMock,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { vanillaStore } from "../../store";
import { useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

const { resetPreview } = getState();

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";

import { Store, vanillaStore } from "../../store";
import { Store, useStore } from "../../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { upcomingCardIds, resetPreview, record, getCurrentCard } = getState();

const flow: Store.flow = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { ComponentType as TYPES } from "@opensystemslab/planx-core/types";
import { cloneDeep, merge } from "lodash";

import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;
const { resetPreview, record, computePassport, getCurrentCard } = getState();

const baseFlow: Store.flow = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

// https://github.com/theopensystemslab/planx-new/pull/430#issue-625111571
const flow: Store.flow = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Store, vanillaStore } from "../store";
import { Store, useStore } from "../store";

// flow preview: https://i.imgur.com/nCov5CE.png

Expand Down Expand Up @@ -106,7 +106,7 @@ const flow: Store.flow = {
},
};

const { getState, setState } = vanillaStore;
const { getState, setState } = useStore;

describe("if I initially pick", () => {
beforeEach(() => {
Expand Down
Loading

0 comments on commit c738c8f

Please sign in to comment.