refactor: add helper function for determining which views should be s…

…crolled to

- The logical condition in the useEffect was somewhat hard to read
- Added a case statement to make the logic more explicit / readable

editor.planx.uk/src/components/Feedback/index.tsx

@@ -100,8 +100,19 @@ const Feedback: React.FC = () => {
 
   const feedbackComponentRef = useRef<HTMLDivElement | null>(null);
 
+  const shouldScrollToView = () => {
+    switch (currentFeedbackView) {
+      case "banner":
+        return false;
+      case "thanks":
+        return false;
+      default:
+        return true;
+    }
+  };
+
   useEffect(() => {
-    if (currentFeedbackView !== "banner" && currentFeedbackView !== "thanks") {
+    if (shouldScrollToView()) {
       feedbackComponentRef.current?.scrollIntoView({
         behavior: "smooth",
         block: "start",