unsupported_team state needs to account for recently changed API mess…

…ages
theopensystemslab · Oct 6, 2023 · dab5692 · dab5692
1 parent 7f6e2ab
commit dab5692
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/editor.planx.uk/src/@planx/components/Pay/Public/Confirm.tsx b/editor.planx.uk/src/@planx/components/Pay/Public/Confirm.tsx
@@ -15,6 +15,7 @@ import ReactMarkdownOrHtml from "ui/ReactMarkdownOrHtml";
 
 import { formattedPriceWithCurrencySymbol } from "../model";
 import InviteToPayForm, { InviteToPayFormProps } from "./InviteToPayForm";
+import { PAY_API_ERROR_UNSUPPORTED_TEAM } from "./Pay";
 
 export interface Props {
   title?: string;
@@ -62,7 +63,7 @@ const PayBody: React.FC<PayBodyProps> = (props) => {
   const isSaveReturn = path === ApplicationPath.SaveAndReturn;
 
   if (props.error) {
-    if (props.error.endsWith("local authority")) {
+    if (props.error.startsWith(PAY_API_ERROR_UNSUPPORTED_TEAM)) {
       return (
         <Card handleSubmit={props.onConfirm} isValid>
           <ErrorSummary role="status" data-testid="error-summary">

diff --git a/editor.planx.uk/src/@planx/components/Pay/Public/Pay.test.tsx b/editor.planx.uk/src/@planx/components/Pay/Public/Pay.test.tsx
@@ -161,7 +161,8 @@ describe("Confirm component without inviteToPay", () => {
 
   it("displays an error and continue-with-testing button if Pay is not enabled for this team", async () => {
     const handleSubmit = jest.fn();
-    const errorMessage = "No pay token found for this local authority";
+    const errorMessage =
+      "GOV.UK Pay is not enabled for this local authority (testing)";
 
     const { user } = setup(
       <Confirm

diff --git a/editor.planx.uk/src/@planx/components/Pay/Public/Pay.tsx b/editor.planx.uk/src/@planx/components/Pay/Public/Pay.tsx
@@ -43,6 +43,9 @@ enum Action {
   Success,
 }
 
+export const PAY_API_ERROR_UNSUPPORTED_TEAM =
+  "GOV.UK Pay is not enabled for this local authority";
+
 function Component(props: Props) {
   const [
     flowId,
@@ -242,7 +245,11 @@ function Component(props: Props) {
           window.location.replace(payment._links.next_url.href);
       })
       .catch((error) => {
-        if (error.response?.data?.error?.endsWith("local authority")) {
+        if (
+          error.response?.data?.error?.startsWith(
+            PAY_API_ERROR_UNSUPPORTED_TEAM,
+          )
+        ) {
           // Show a custom message if this team isn't set up to use Pay yet
           dispatch(Action.StartNewPaymentError);
         } else {