chore: Tidy up types

theopensystemslab · Feb 16, 2024 · f66e4bd · f66e4bd
1 parent f9771c0
commit f66e4bd
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 15 deletions.
diff --git a/api.planx.uk/types.ts b/api.planx.uk/types.ts
@@ -39,7 +39,6 @@ export interface UserData {
   data?: Record<string, any>;
   auto?: boolean;
   override?: Record<string, any>;
-  feedback?: string;
 }
 
 export type Breadcrumb = Record<string, UserData>;

diff --git a/editor.planx.uk/src/@planx/components/Result/Public/index.tsx b/editor.planx.uk/src/@planx/components/Result/Public/index.tsx
@@ -86,6 +86,7 @@ const Responses = ({
 
 const Result: React.FC<Props> = ({
   allowChanges = false,
+  handleSubmit,
   headingColor,
   headingTitle = "",
   description = "",
@@ -103,7 +104,7 @@ const Result: React.FC<Props> = ({
         description={description}
         color={headingColor}
       />
-      <Card>
+      <Card handleSubmit={handleSubmit}>
         <Box mt={4} mb={3}>
           <Typography variant="h2" gutterBottom>
             {reasonsTitle}

diff --git a/editor.planx.uk/src/pages/FlowEditor/lib/store/index.ts b/editor.planx.uk/src/pages/FlowEditor/lib/store/index.ts
@@ -26,7 +26,6 @@ export declare namespace Store {
     data?: Record<string, any>;
     auto?: boolean;
     override?: Record<string, any>;
-    feedback?: string;
   };
   export type breadcrumbs = Record<nodeId, userData>;
   export type cachedBreadcrumbs = Record<nodeId, userData> | undefined;

diff --git a/editor.planx.uk/src/pages/FlowEditor/lib/store/preview.ts b/editor.planx.uk/src/pages/FlowEditor/lib/store/preview.ts
@@ -283,17 +283,10 @@ export const previewStore: StateCreator<
 
     if (userData) {
       // add breadcrumb
-      const {
-        answers = [],
-        data = {},
-        auto = false,
-        override,
-        feedback,
-      } = userData;
+      const { answers = [], data = {}, auto = false, override } = userData;
 
       const breadcrumb: Store.userData = { auto: Boolean(auto) };
       if (answers?.length > 0) breadcrumb.answers = answers;
-      if (feedback) breadcrumb.feedback = feedback;
 
       const filteredData = objectWithoutNullishValues(data);
       if (Object.keys(filteredData).length > 0) breadcrumb.data = filteredData;

diff --git a/editor.planx.uk/src/pages/Preview/Questions.tsx b/editor.planx.uk/src/pages/Preview/Questions.tsx
@@ -135,17 +135,16 @@ const Questions = ({ previewEnvironment }: QuestionsProps) => {
         data = undefined,
         answers = [],
         auto = false,
-        feedback = undefined,
       } = (() => {
         try {
-          const { answers = [], data, auto, feedback } = userData as any;
-          return { answers: answers.filter(Boolean), data, auto, feedback };
+          const { answers = [], data, auto } = userData as any;
+          return { answers: answers.filter(Boolean), data, auto };
         } catch (err) {
           return {};
         }
       })();
 
-      record(id, { answers, data, auto, feedback });
+      record(id, { answers, data, auto });
     };
 
   const goBack = useCallback(() => {