Upgrade Node 14 to Node LTS (16.3.1) (#776)

theopensystemslab · Dec 18, 2021 · ff3877b · ff3877b
1 parent 97f404a
commit ff3877b
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 11 deletions.
diff --git a/.github/workflows/pull-request-main.yml b/.github/workflows/pull-request-main.yml
@@ -10,8 +10,8 @@ env:
   FULL_DOMAIN: ${{ github.event.number }}.planx.pizza
   PULLREQUEST_ID: ${{ github.event.number }}
   EDITOR_DIRECTORY: editor.planx.uk
-  PNPM_VERSION: 6.14.7
-  NODE_VERSION: 14
+  PNPM_VERSION: 6.24.1
+  NODE_VERSION: 16.13.1 # 16.13.1 = LTS
 
 jobs:
   integration_tests:

diff --git a/.github/workflows/push-main.yml b/.github/workflows/push-main.yml
@@ -10,6 +10,7 @@ concurrency: staging_environment
 
 env:
   DEPLOYMENT_ENVIRONMENT: staging
+  NODE_VERSION: 16.13.1 # 16.13.1 = LTS
 
 jobs:
   test_and_build:
@@ -19,7 +20,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: "14"
+          node-version: ${{ env.NODE_VERSION }}
       # https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#using-the-cache-action
       - name: NPM cache
         uses: actions/cache@v2
@@ -76,9 +77,9 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 1
-      - uses: actions/setup-node@v1
+      - uses: actions/setup-node@v2
         with:
-          node-version: 14.x
+          node-version: ${{ env.NODE_VERSION }}
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:

diff --git a/.github/workflows/push-production.yml b/.github/workflows/push-production.yml
@@ -10,6 +10,7 @@ concurrency: production_environment
 
 env:
   DEPLOYMENT_ENVIRONMENT: production
+  NODE_VERSION: 16.13.1 # 16.13.1 = LTS
 
 jobs:
   test_and_build:
@@ -19,7 +20,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: "14"
+          node-version: ${{ env.NODE_VERSION }}
       # https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#using-the-cache-action
       - name: NPM cache
         uses: actions/cache@v2
@@ -76,9 +77,9 @@ jobs:
       - uses: actions/checkout@v2
         with:
           fetch-depth: 1
-      - uses: actions/setup-node@v1
+      - uses: actions/setup-node@v2
         with:
-          node-version: 14.x
+          node-version: ${{ env.NODE_VERSION }}
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v1
         with:

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16.13.0
+v16.13.1
diff --git a/api.planx.uk/Dockerfile b/api.planx.uk/Dockerfile
@@ -1,4 +1,5 @@
-FROM node:14.4.0-alpine as base
+# 16.13.1 = LTS
+FROM node:16.13.1-alpine as base
 
 WORKDIR /api
 RUN npm install -g pnpm

diff --git a/sharedb.planx.uk/Dockerfile b/sharedb.planx.uk/Dockerfile
@@ -1,4 +1,5 @@
-FROM node:14.4.0-alpine as base
+# 16.13.1 = LTS
+FROM node:16.13.1-alpine as base
 
 WORKDIR /sharedb
 RUN npm install -g pnpm