Mh/remove feedback fish (#2775)

theopensystemslab · Feb 16, 2024 · ff55003 · ff55003
1 parent ed7d245
commit ff55003
Show file tree

Hide file tree

Showing 18 changed files with 93 additions and 723 deletions.
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -209,7 +209,6 @@ jobs:
           REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
           REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
           REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
           REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
           REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
           # needed because there's no API to change google's allowed OAuth URLs
@@ -224,7 +223,6 @@ jobs:
           REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
           REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
           REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
           REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
           REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
           REACT_APP_GOOGLE_OAUTH_OVERRIDE: https://api.editor.planx.dev

diff --git a/.github/workflows/push-main.yml b/.github/workflows/push-main.yml
@@ -54,7 +54,6 @@ jobs:
         working-directory: editor.planx.uk
         env:
           REACT_APP_API_URL: https://api.editor.planx.dev
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
           REACT_APP_HASURA_URL: https://hasura.editor.planx.dev/v1/graphql
           REACT_APP_SHAREDB_URL: wss://sharedb.editor.planx.dev
           REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}

diff --git a/.github/workflows/push-production.yml b/.github/workflows/push-production.yml
@@ -54,7 +54,6 @@ jobs:
         working-directory: editor.planx.uk
         env:
           REACT_APP_API_URL: https://api.editor.planx.uk
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
           REACT_APP_HASURA_URL: https://hasura.editor.planx.uk/v1/graphql
           REACT_APP_SHAREDB_URL: wss://sharedb.editor.planx.uk
           REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}

diff --git a/api.planx.uk/modules/admin/controller.ts b/api.planx.uk/modules/admin/controller.ts
diff --git a/api.planx.uk/modules/admin/docs.yaml b/api.planx.uk/modules/admin/docs.yaml
diff --git a/api.planx.uk/modules/admin/routes.ts b/api.planx.uk/modules/admin/routes.ts
@@ -7,18 +7,10 @@ import { getHTMLExport, getRedactedHTMLExport } from "./session/html";
 import { generateZip } from "./session/zip";
 import { getSessionSummary } from "./session/summary";
 import { getDigitalPlanningApplicationPayload } from "./session/digitalPlanningData";
-import { validate } from "../../shared/middleware/validate";
-import { downloadFeedbackCSVSchema } from "./service/feedback/types";
-import { downloadFeedbackCSV } from "./controller";
 
 const router = Router();
 
 router.use("/admin/", usePlatformAdminAuth);
-router.get(
-  "/admin/feedback",
-  validate(downloadFeedbackCSVSchema),
-  downloadFeedbackCSV,
-);
 
 // TODO: Split the routes below into controller and service components
 router.get("/admin/session/:sessionId/xml", getOneAppXML);

diff --git a/api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.test.ts b/api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.test.ts
diff --git a/api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.ts b/api.planx.uk/modules/admin/service/feedback/downloadFeedbackCSV.ts