chore: Add manually triggered CI test suite #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
|
Next steps after this is merged is to revive #1496 and break down these steps into reusable workflows. |
jessicamcinchak
approved these changes
May 10, 2023
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v1 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.PIZZA_AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
will these PIZZA_ variables actually work if this is triggered on the main branch do you think? Just thinking about recent scenarios of broken Notify templates where it'd be convenient to check/compare state of main, not a local PR branch?
testing actions is tricky though so happy for this to merge & fix forward if needed 🙂
There was a problem hiding this comment.
These aren't specific to a Vultr deployment but general AWS keys. I was aiming to change as little as possible to make future de-duping easier later and I think this should work 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To validate the state of a particular branch, it is helpful to be able to trigger just the automated tests for that branch.
This PR adds a CI workflow to run automated tests on demand.
This adds some duplication but well worth it for a quick way to sense-check
mainwith minimal faff.