Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sticky help button #2203

Merged
merged 15 commits into from
Sep 19, 2023
Merged

feat: Sticky help button #2203

merged 15 commits into from
Sep 19, 2023

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Sep 5, 2023 •
edited
Loading

Update of help button

Related to ticket:
https://trello.com/c/EqgNQd1Y/2586-make-help-text-icon-stand-out-more

PR modifies the help icon to be a button that sticks to the header on scroll.

Changes:

  • Button is changed from an icon to the word "Help"
  • Button remains in same DOM order (after title + description)
  • Button retains minimum of 44px in each dimension to maintain click/touch area (spec as W3C 2.5 AAA)
  • On scroll the button sticks to the header in a sticky bar with the back button

Example:
https://2203.planx.pizza/buckinghamshire/help-text-experiment/preview

@ianjon3s ianjon3s added the demo Demo environment being used by an external team label Sep 5, 2023
@ianjon3s ianjon3s changed the title Ian/sticky help button fixed position right demo: Sticky help button -- fixed position right Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s changed the title demo: Sticky help button -- fixed position right feat: Sticky help button Sep 6, 2023
@ianjon3s ianjon3s removed the demo Demo environment being used by an external team label Sep 6, 2023
@ianjon3s
Copy link
Contributor Author

ianjon3s commented Sep 6, 2023

Make help text icon stand out more

@ianjon3s ianjon3s marked this pull request as ready for review September 6, 2023 12:54
@ianjon3s ianjon3s requested a review from a team September 6, 2023 12:54
jessicamcinchak
jessicamcinchak approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as-expected for me! I love this future of clearly named styled components 💅

@ianjon3s ianjon3s force-pushed the ian/sticky-help-button--fixed-position-right branch from be194e4 to e13be74 Compare September 7, 2023 15:41
@ianjon3s ianjon3s force-pushed the ian/sticky-help-button--fixed-position-right branch from e13be74 to 401a14e Compare September 19, 2023 10:25
@ianjon3s ianjon3s merged commit 7bdc025 into main Sep 19, 2023
@ianjon3s ianjon3s deleted the ian/sticky-help-button--fixed-position-right branch September 19, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @jessicamcinchak