Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow NextSteps without URL to continue flow #2218

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: Allow NextSteps without URL to continue flow #2218

merged 1 commit into from
Sep 18, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 15, 2023 •
edited
Loading

What does this PR do?

  • Makes the URL field optional in the NextSteps component
  • If not populated, the next steps button acts as a "Continue"

Questions

  • Does this achieve what we want, or is branching here essential from within the component? If branching is required, I'll explore this in a follow on PR
  • Do we want to style the buttons and links differently (as I've done here) or is it better than they look visually consistent (semantic HTML still describes the difference between the options).
Screen.Recording.2023-09-15.at.14.35.12.mov

@DafyddLlyr
Copy link
Contributor Author

Improve Next steps component in guidance services "If no URL, act as a Continue Button"

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr marked this pull request as ready for review September 17, 2023 15:51
@DafyddLlyr DafyddLlyr requested a review from a team September 17, 2023 15:51
jessicamcinchak
jessicamcinchak approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice & simple! Week before last we decided in pre-planning that branching was non-essential here, and could always be accomplished with content / SetValue's if necessary in particular cases

Current styling choices make sense to me ➕

@DafyddLlyr DafyddLlyr merged commit 1ec5003 into main Sep 18, 2023
@DafyddLlyr DafyddLlyr deleted the dp/next-steps-url branch September 18, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak