Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incomplete multi-character sanitation #2228

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: Incomplete multi-character sanitation #2228

merged 1 commit into from
Sep 20, 2023

Conversation

DafyddLlyr
Copy link
Contributor

Please see https://github.com/theopensystemslab/planx-new/security/code-scanning/7

The same PR will shortly follow on planx-core

@DafyddLlyr DafyddLlyr requested a review from a team September 20, 2023 08:41
@DafyddLlyr DafyddLlyr mentioned this pull request Sep 20, 2023
Merged
jessicamcinchak
jessicamcinchak approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a good reminder that we should be able to strip out a lot of this editor "Send" logic now I think that planx-core is capturing both BOPS & CSV generation (but maybe still an outstanding question of public versus admin client if I remember right? let's briefly discuss at dev call later?)

@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

DafyddLlyr added a commit to theopensystemslab/planx-core that referenced this pull request Sep 20, 2023
@DafyddLlyr
fix: Incomplete multi-character sanitation (#134)
7e31b2e 
Pleasee see theopensystemslab/planx-new#2228
@DafyddLlyr
Copy link
Contributor Author

This one is a good reminder that we should be able to strip out a lot of this editor "Send" logic now I think that planx-core is capturing both BOPS & CSV generation (but maybe still an outstanding question of public versus admin client if I remember right? let's briefly discuss at dev call later?)

Yep - 100%....! I had this same question also - I think we can update this and remove it now.

@DafyddLlyr DafyddLlyr merged commit a37f659 into main Sep 20, 2023
@DafyddLlyr DafyddLlyr deleted the dp/incomplete-multi-character-sanitation branch September 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak