feat: Create user endpoint, manage team members by email and teamSlugs #2236
Conversation
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (2)
|
DafyddLlyr
force-pushed
the
dp/create-user-endpoint
branch
2 times, most recently
from
0007cf5 to
a07c55c
Compare
| const mockGetTeamBySlug = jest.fn().mockResolvedValue(mockTeam); | ||
| const mockGetUserByEmail = jest.fn().mockResolvedValue(mockUser); | ||
|
|
||
| jest.mock("@opensystemslab/planx-core", () => { |
There was a problem hiding this comment.
At some point soon I'm going to look at how Jest can automock modules - I think this will allow us much easier setup and less repetition.
hasura.planx.uk/metadata/tables.yaml
Outdated
There was a problem hiding this comment.
Changes in this file were required as queries were failing which should have been allowed - apologies for the nosie.
| return res.status(500).json({ message: "Failed to change role" }); | ||
|
|
||
| res.send({ message: "Successfully changed role" }); | ||
| export const changeMemberRole: UpsertMember = async (req, res, next) => { |
There was a problem hiding this comment.
These simple methods should show request / response logic handled in the controller, whilst "business logic" is handled in the service.
| role, | ||
| }: UpsertMember) => { | ||
| const $client = getClient(); | ||
| const { user, team } = await getUserAndTeam({ userEmail, teamSlug }); |
There was a problem hiding this comment.
Doing multiple round trips to the DB to get these details feels pretty awkward. If / when we expose this functionality into the UI it would be worth having userId and teamId upfront to make these requests.
|
Removed vultr server and associated DNS entries |
DafyddLlyr
changed the title
|
Moved (briefly!) back to draft - there's a few outstanding docs tidy ups needed I've just noticed on the Pizza sorry! |
Implemented in theopensystemslab/planx-new#2236
- Standardise error handling - Update tests
DafyddLlyr
force-pushed
the
dp/create-user-endpoint
branch
from
a07c55c to
40ed87d
Compare
| new ServerError({ message: "Failed to create user", cause: error }), | ||
| ); | ||
| } | ||
| }; |
There was a problem hiding this comment.
would we benefit from a "RemoveUser" here too that, rather than delete the actual record, nullifies the email field to lock them out? Probably not crucial yet, but it feels like the tiny missing piece from an otherwise very useful set of user & team management endpoints ! And it would probably encourage better house-keeping around this.
There was a problem hiding this comment.
Good shout - I'll pick this up in a quick follow on PR.
What does this PR do?
platformAdminroleDepends on theopensystemslab/planx-core#137