Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add section descriptions #2240

Merged
merged 7 commits into from
Sep 28, 2023
Merged

feat: Add section descriptions #2240

merged 7 commits into from
Sep 28, 2023

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Sep 27, 2023 •
edited
Loading

Summary

  • PR adds the option to add a rich-text description to sections
  • <dl> structure is maintained, I've checked and nesting a <div> inside a <dl> is valid HTML source
  • Tests and storybook updated accordingly

Related to Trello card:
https://trello.com/c/SGy6v0Sm/2587-investigate-section-descriptions

Example:
https://2240.planx.pizza/lambeth/apply-for-prior-approval/preview

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review September 28, 2023 08:19
@ianjon3s ianjon3s requested a review from a team September 28, 2023 08:20
DafyddLlyr
DafyddLlyr approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👍

@ianjon3s
Copy link
Contributor Author

[Investigate] section descriptions

@ianjon3s
Copy link
Contributor Author

Thanks @DafyddLlyr !

@ianjon3s
Copy link
Contributor Author

Merging this now and will apply any subsequent changes from PO feedback

@ianjon3s ianjon3s merged commit bfb3fca into main Sep 28, 2023
@ianjon3s ianjon3s deleted the ian/section-descriptions branch September 28, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @DafyddLlyr