-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to use "Pay without pay" and show error in cases of undefined fee #2284
Conversation
Removed vultr server and associated DNS entries |
const handleSubmit = jest.fn(); | ||
const { container } = setup(<Pay handleSubmit={handleSubmit} />); | ||
const results = await axe(container); | ||
expect(results).toHaveNoViolations(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! All behaviour working as expected - thanks for also adding more a11y tests which is always good to see.
A few small comments on the code, but no show stoppers.
Changes:
NaN
/undefined
fees are handledprops.fn
) is undefined when Pay is reached, then automatically skip the Pay component. This led to real applications being successfully submitted without paying because of a content error a few weeks ago.props.fn
is undefined when Pay is reached, display an error and do not let the applicant continue. An airbrake error including thesessionId
is also thrown/should be picked up in Slack.Testing:
Future scope / not addressed here: