fix: Correctly parse and transform strings to date in /webhook APIs
#2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Oct 6, 2023
| @@ -4,7 +4,7 @@ import { ScheduledEventResponse } from "../../../../hasura/metadata"; | |||
|
|
|||
| export const createSessionEventSchema = z.object({ | |||
| body: z.object({ | |||
| createdAt: z.string().transform((val) => new Date(val)), | |||
| createdAt: z.string().pipe(z.coerce.date()), | |||
There was a problem hiding this comment.
This is functionally the same, but syntactically a little nicer colinhacks/zod#879 (comment)
jessicamcinchak
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit this issue when troubleshooting E2E test (this doesn't fix them yet! 😅)
The change introduced in #2252 validates that incomming requests are valid (e.g. dates), and then hands over the request type to the
ValidatedRequestHandlertype.What I missed is that we're never passing along the parsed request to the next middleware layer (but it does pass the type as mentioned above).
This means we end up with strings being passed into functions that expect
Dateobjects. When running E2E tests a number of API requests fail as a result.