feat: Catch permission errors #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/fallback-permissions-error
branch
3 times, most recently
from
20d6842 to
10a0b6a
Compare
DafyddLlyr
force-pushed
the
dp/fallback-permissions-error
branch
from
10a0b6a to
9f57d40
Compare
DafyddLlyr
changed the title
DafyddLlyr
commented
Oct 9, 2023
| @@ -45,14 +48,40 @@ const publicHttpLink = createHttpLink({ | |||
| headers: { "x-hasura-role": "public" }, | |||
| }); | |||
|
|
|||
| const errorLink = onError(({ graphQLErrors }) => { | |||
| const handlePermissionErrors = (message: string, operation: Operation) => { | |||
| const permissionErrors = [ | |||
There was a problem hiding this comment.
There are a number of issues on the Hasura graphql-engine repo requesting better error messages - please see explanation here for context hasura/graphql-engine#6716 (comment)
jessicamcinchak
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Looks like Vultr is still reporting global deploy delays, but code looks good here & works for me locally following same steps in your demo !
Thanks for checking that - having issue after issue with Vultr yesterday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demo
In the video below, I removed my
platformAdminrole and unhid the "create flow" button to test what this would look like.Screen.Recording.2023-10-09.at.20.17.36.mov