-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create new api
role in Hasura
#2294
Conversation
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (14)
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All really clear, thanks for continuing to pick this up !
What does this PR do?
api
role in HasuraWhat's the motivation behind this?
I'm working towards https://trello.com/c/qSCoDRAO/2650-implement-editor-permissions-throughout-the-api which has two main aims -
The first step has been pretty well started in previous PRs. Adding an
api
role will allow us to scope service → API requests appropriately when a service has authenticated to the API (e.g. through theuseHasuraAuth()
middleware).The permission set outlined here is based on queries currently made by the two admin GraphQL clients currently used in the API.
Next steps...
$admin
client from APIadminGraphQLClient
from APIapi
role for service → API requests.I'll likely split the above into a few PRs just to make them a bit more manageable.
Nice to have?
Porting the introspection tests from JavaScript / Jest to Gherkin could be a really nice tidy up. I think it would be approx 10% of the number of lines of code that we currently have and be a lot easier to maintain and parse. This is not a very high priority tbh!