feat: Use $api client for requests from Hasura → API
#2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/use-api-client-for-useHasuraAuth
branch
from
166fa8e to
336ef97
Compare
DafyddLlyr
force-pushed
the
dp/use-api-client-for-useHasuraAuth
branch
from
336ef97 to
2717e01
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
changed the title
$api client for request from Hasura → API$api client for requests from Hasura → API
DafyddLlyr
commented
Oct 12, 2023
| */ | ||
| export const $admin = new CoreDomainClient({ | ||
| auth: { adminSecret: process.env.HASURA_GRAPHQL_ADMIN_SECRET! }, | ||
| export const $api = new CoreDomainClient({ |
There was a problem hiding this comment.
I'm not totally thrilled with the name of this at it feels a little unspecific, but it follows the existing pattern of $<ROLE> being the client for that role.
We could rename getClient() -> getUserClient() which returns a $user, but similarly this feels a little unclear as you could end up with $user.user.addUser(newUser) 🫠
jessicamcinchak
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
$adminclient with the$apiclient (see comment on naming conventions) which is scoped to the "api" roleuseHasuraAuth()auth middleware - these functions are all triggered by HasuraWhat about tests?
Yep, this is tricky. Introspection tests cover the permissions the
$apiclient has here. Some of the functionality is covered by E2E tests (send, invite to pay) - some is not (submit, export).I think the best solution here in the medium term is to probably work to improve our E2E test coverage for high-priority functionality.