Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query & display Flood Risk Zones in PlanningConstraints #2302

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Oct 12, 2023

Changes:

  • Adds values flood, flood.zone.1, flood.zone.2 and flood.zone.3 to the planning constraints check (only adds granular entries if flood is true, consistent with Article 4 granular variables)

I hit two quirks with Planning Data that I've raised with Matt L, and expect to be updated soon on their side. When it is, the dropdown will populate as expected, no extra code changes required (so no need to block initial merge I think!):

  • Planning data hasn't populated the "text" for flood-risk-zone metadata (which is used to render the contextual paragraphs in the dropdown)
  • Planning data hasn't populated the "name" for flood-risk-zone entities (which is used to render the bullet-pointed list in the dropdown)

Address in a flood zone for testing: 47, COBOURG ROAD, SOUTHWARK, SE5 0HU

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review October 13, 2023 11:34
@jessicamcinchak jessicamcinchak requested a review from a team October 13, 2023 11:34
@@ -23,6 +23,7 @@ const CATEGORY_COLORS: Record<string, string> = {
"Heritage and conservation": "#EDDCD2",
Ecology: "#E0EFCC",
Trees: "#DBE7E4",
Flooding: "#ECECEC",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to better suggestions than grey here! Easy to adjust later though.

@jessicamcinchak jessicamcinchak merged commit 419a1bc into main Oct 13, 2023
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/flood-zones branch October 13, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants