chore: Bump API memory (and CPU) #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
Currently, the API is hitting 100% CPU on prod when handling submissions.
Even when submissions succeed, it causes the API to restart which means that subsequent calls to the API (e.g. to proxy image requests, or trigger Slack notifications) then fail.
What's the solution
Doubling the memory also bumps the CPU size (Fargate docs)
If we can get this to prod and test (via
/adminendpoints) I'd hope we can notice a difference on Fargate task.Next steps...
I'd like to take a look at (and profile) what I suspect the culprit is here (
computeBOPSParams()) and see if there are any code changes we can make that don't purely rely on just upping memory / CPU. This should buy us some time though!