chore: Overwrite records on data-sync conflict #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See context on OSL Slack - https://opensystemslab.slack.com/archives/C01E3AC0C03/p1696942132535689
Currently, we don't overwrite DB records on conflict - we skip them. This can lead to inconsistencies (as on the above thread), could potentially lead to permissions diverging between staging and prod, and also causes this new issue raised here where the prod boundary has not been copied across to staging - https://trello.com/c/hreL5mn4/2665-site-doesnt-have-address-showing-london-map-extract-on-bucks-service