fix: Change external portal cache strategy #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Oct 25, 2023
| gql` | ||
| query GetFlow($id: uuid!) { | ||
| flows_by_pk(id: $id) { | ||
| const ExternalPortal: React.FC<any> = (props) => { |
There was a problem hiding this comment.
React.memo() was caching this component and causing it to update in an unexpected manner.
There's nothing particularly "expensive" going on here apart from the query. By adding an id field to the query response though Apollo will just cache this for us in the InMemoryCache and stop the query being repeated anyway.
The big diff here is a bit weird but it's pretty much just the indentation of React.memo() being removed.
DafyddLlyr
commented
Oct 25, 2023
| // If the flow referenced by an external portal has been deleted (eg !data), | ||
| // still show a "Corrupted" node so that editors have a visual cue to "delete". | ||
| // Until deleted, the flow schema will still contain a node reference to this portal causing dataMerged to fail | ||
| if (!loading && !data?.flows_by_pk) { |
There was a problem hiding this comment.
Checking this loading state stops the component flashing to "Corrupted" between updates.
DafyddLlyr
force-pushed
the
dp/change-external-portal-cache-strategy
branch
from
236b930 to
df257fc
Compare
jessicamcinchak
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a small visual issue flagged here on OSL Slack where External Portals do not update as expected
Before
Screen.Recording.2023-10-25.at.21.24.11.mov
After
Screen.Recording.2023-10-25.at.22.12.38.mov