Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase spacing above "Name the site" input #2342

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 25, 2023

Quick fix for an outstanding issue I noticed when recently discussing this component.

The MapContainer currently does not encapsulate the <MapFooter> correctly as the MyMap element within it is styled to have height: "100%". This means that any elements beneath it (such as the "Name the site" input) are not spaced correctly.

Before After
Spacing image image
Map Container image image

@DafyddLlyr DafyddLlyr changed the title fix: Increase spacing above Name the site input fix: Increase spacing above "Name the site" input Oct 25, 2023
@DafyddLlyr DafyddLlyr force-pushed the dp/name-the-site-spacing branch from d0f59bc to b3a7d41 Compare October 25, 2023 19:44
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team October 25, 2023 21:08
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 25, 2023 21:08
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up, much better!

@DafyddLlyr DafyddLlyr merged commit 3750b86 into main Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants