Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Capture user agent and referrer analytics #2349

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 26, 2023

What does this PR do?

  • Appends user agent details to analytics, using the Bowser library
  • Appends referrer details to analytics

Screenshots

image image

@DafyddLlyr DafyddLlyr requested a review from a team October 26, 2023 20:35
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.analytics permissions:

    insert select update delete
    public /
    2 added column permissions
    insert select update
    public ➕ referrer
    ➕ user_agent

@DafyddLlyr DafyddLlyr marked this pull request as draft October 26, 2023 20:42
@DafyddLlyr DafyddLlyr removed the request for review from a team October 26, 2023 20:42
@DafyddLlyr DafyddLlyr force-pushed the dp/device-info-analytics branch from 52298d1 to 13beef4 Compare October 26, 2023 20:58
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr changed the title feat: Capture user agent analytics feat: Capture user agent and referrer analytics Oct 26, 2023
@DafyddLlyr DafyddLlyr force-pushed the dp/device-info-analytics branch from 5f25af7 to b4460c4 Compare October 26, 2023 21:27
@DafyddLlyr DafyddLlyr requested a review from a team October 27, 2023 07:00
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 27, 2023 07:00
@DafyddLlyr
Copy link
Contributor Author

Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and worked as expected for me on the pizza 👍

@@ -129,7 +130,7 @@ export const AnalyticsProvider: React.FC<{ children: React.ReactNode }> = ({

async function track(direction: AnalyticsLogDirection, analyticsId: number) {
const metadata = getNodeMetadata();
const node_title =
const nodeTitle =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot and tidy up 🙌

@DafyddLlyr DafyddLlyr merged commit a9db181 into main Oct 31, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/device-info-analytics branch October 31, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants