Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve flakey E2E tests #2351

Merged
merged 3 commits into from
Nov 1, 2023
Merged

fix: Improve flakey E2E tests #2351

merged 3 commits into from
Nov 1, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 27, 2023 •
edited
Loading

What does this PR do?

  • Reduces / removes flakiness of user data persists on page refresh @regression E2E Playwright test
  • I've re-run this multiple times on CI (7-10 times?) without a failure so I've got a good degree of confidence it's better than the current implementation
  • This is achieved by wrapping actions in a Promise.all()

Docs

@DafyddLlyr DafyddLlyr force-pushed the dp/flakey-test-improvement branch from 5ca191f to 605079b Compare October 27, 2023 10:29
@DafyddLlyr DafyddLlyr requested a review from a team October 30, 2023 15:09
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 30, 2023 15:09
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

Mike-Heneghan
Mike-Heneghan reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DafyddLlyr

I tried having wee look over this and although it looks good to me I'm very aware I'm not very familiar with our E2E tests.

Maybe we could use this PR as a vehicle for discussing E2E?

e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts Outdated Show resolved Hide resolved
e2e/tests/ui-driven/src/create-flow/helpers.ts Outdated Show resolved Hide resolved
@DafyddLlyr
Copy link
Contributor Author

Maybe we could use this PR as a vehicle for discussing E2E?

Thanks for the reminder - put a slot in the calendar tomorrow morning and we can cover this 👍

@DafyddLlyr DafyddLlyr merged commit 3474a45 into main Nov 1, 2023
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/flakey-test-improvement branch November 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Heneghan Mike-Heneghan Mike-Heneghan left review comments

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DafyddLlyr @jessicamcinchak @Mike-Heneghan